[Geany-devel] [patch] Improved documents list sorting

[Enrico Tröger]

On Sat, 8 May 2010 14:24:21 +0200, Enrico wrote:

> On Tue, 27 Apr 2010 18:05:05 +0200, Colomban wrote:
> 
> > Enrico Tröger a écrit :
> > > On Tue, 27 Apr 2010 16:54:48 +0200, Enrico wrote:
> > > 
> > >> On Mon, 26 Apr 2010 15:42:25 +0200, Colomban wrote:
> > >>
> > >>> Hi!
> > >> Ho!
> > Hey!
> > 
> > >> It might be better to take the more memory to get a little more
> > >> speed, i.e. to not loose too much speed :(. 
> > >> Sorting of the list happens on each newly opened document and
> > >> maybe on closing documents and even when switching tabs as I just
> > >> noticed while
> > > 
> > > We don't re-sort on closing documents.
> > > So, in contrary to my previous opinion, I'd vote to go the easy
> > > way and compute the keys on each run instead of polluting the
> > > memory.
> > I just did naive and inexact benchmarks (with a watch, haha), and it
> > seems that the naive solution is not so slow (tested with "only" 300
> > files: 122s vs 125s [1]); and the more complex solution seems to be
> > as fast as without any special sorting function.
> > So I think I'll vote too for the naive solution - and anyway, is
> > there anybody here that uses an editor with 300 files at once?
> 
> Before the patch gets lost, I'd like to commit it soon if there are no
> objections.


Committed now. Thanks again for the patch and the many efforts.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100514/18fd5da7/attachment.pgp>