[Geany-devel] SF.net SVN: geany:[4882] trunk

[Enrico Tröger]

On Sat, 08 May 2010 13:10:14 +0000, eht16 at users.sourceforge.net wrote:

> Revision: 4882
>           http://geany.svn.sourceforge.net/geany/?rev=4882&view=rev
> Author:   eht16
> Date:     2010-05-08 13:10:14 +0000 (Sat, 08 May 2010)
> 
> Log Message:
> -----------
> Apply foreground and background colours of the folding margin style
> properly (closes #2998347).
> 
>[...]
>
> +	/* TODO maybe we want to split the colour and hicolour to
> allow more fine-grained control */ SSM(sci, SCI_SETFOLDMARGINCOLOUR,
> 1, invert(common_style_set.styling[GCS_MARGIN_FOLDING].background));
> -	/*SSM(sci, SCI_SETFOLDMARGINHICOLOUR, 1,
> invert(common_style_set.styling[GCS_MARGIN_FOLDING].background));*/
> +	SSM(sci, SCI_SETFOLDMARGINHICOLOUR, 1,
> invert(common_style_set.styling[GCS_MARGIN_FOLDING].background));

With this change, the style "margin_folding" in filetypes.common is
used to set the background colour of the folding margin and the
foreground colour of the fold markers. This is now analogue to the line
number and markers margin.

However, for the folding margin Scintilla provides more styling
settings, i.e. we can set a background colour and a highlight colour.
This way the margin can be easily shaded and so better differentiated
from the other margins.
By the above change, this functionality is disabled and the folding
margin always has only a single background colour.

I wonder whether we should add another setting in filetypes.common to
allow setting the background as well as highlight colour for the
folding margin or whether it is good enough as it is by now (it's the
same settings as for the other two margins).


I personally don't mind, I don't use folding most of the time and so
also have the folding margin disabled.

Other opinions?


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100508/82caf971/attachment.pgp>