[Geany-devel] GtkRecentManager slowness - Re: [patch] Improved documents list sorting

[Enrico Tröger]

On Sun, 9 May 2010 15:33:47 +0200 (CEST), Colomban wrote:

> > On Sat, 8 May 2010 15:37:53 +0200 (CEST), lists.ban at herbesfolles.org
> > wrote:
> >
> >> > On Thu, 29 Apr 2010 18:47:41 +0200, Colomban wrote:
> >> >
> >> >> Nick Treleaven a écrit :
> >> >> > On Thu, 29 Apr 2010 17:46:45 +0200
> >> >> > Enrico Tröger <enrico.troeger at uvena.de> wrote:
> >> >> >
> >> >> >>> Yes, I think it could be a (hidden?) option at least until
> >> >> >>> it got fixed at the GTK level. Note that anyway it is only
> >> >> >>> available if Geany was compiled against GTK >= 2.12.
> >> >> >> Which is probably true for most Geany users (using GTK >=
> >> >> >> 2.12).
> >> >> >
> >> >> > (After a quick Grep it seems to me it's 2.10, not 2.12).
> >> >> Yes, actually. I don't know why I've said 2.12 sorry.
> >> >>
> >> >> >> Maybe we could generally disable calling
> >> >> >> gtk_recent_manager_add_item() when opening more than one
> >> >> >> file at once because maybe the user doesn't want to have
> >> >> >> them added at all. Though, no idea if this is a valid
> >> >> >> assumption and also no idea how to verify it :).
> >> >> I don't think so. I use that recent files feature, not that much
> >> >> but I use it. And I would be definitely surprised if a file is
> >> >> added to it if I open it alone but not if I open another file
> >> >> together. But of course if we open 15 files and only 10 are
> >> >> shown in the recent list, the first 5 might haven't be added at
> >> >> all. It would probably be a little tricky to do that but it's
> >> >> probably the less wrong workaround.
> >> >
> >> > I'm not sure what you mean. Only add the last 10 files when
> >> > opening multiple files at once?
> >> Yes. Or even better than "the last 10", the number returned by
> >> gtk_recent_manager_get_limit().
> >
> > According to the docs, the "limit" property defaults to -1 which
> > probably means 'no limit'. So, if the default is no limit, we would
> > not gain much by it, I'm afraid.
> > Am I missing something?
> Hum, no you're right, I talked way too fast.
> The number of actually displayed items is in
> GtkSettings:gtk-recent-files-limit. But the default seems to be 50
> (on a Ubuntu 8.10 live CD at least), which is still a lot to add --
> less than 300 but still.
> But hum, do you set it yourself in geany? (since there is only 10
> actually displayed IIRC)

In Geany, we don't use the GTK setting but our own instead. This is
because our setting is older than GTK's :). The GtkRecentManager exists
only since GTK 2.10 but our MRU list implementation is older IIRC. We
only add the recent files to GTK's system so they are visible there.


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100509/acabae35/attachment.pgp>