[Geany-devel] [Patch] Avoid crash when opening project properties dialog

[Lex Trotman]

On 10 March 2010 04:39, Nick Treleaven <nick.treleaven at btinternet.com>wrote:

> On Tue, 9 Mar 2010 19:48:39 +1100
> Lex Trotman <elextr at gmail.com> wrote:
>
> > > ft is NULL there, which looks like a valid value, since ft is tested
> for
> > > NULL explicitly in line 1878. So I propose the following patch.
> ...
>
> > Thanks, one more change is needed, ft isn't initialised to NULL so on my
> > machine it doesn't crash :-S, needs the declaration of ft to be
> initialised
> > to NULL so your test will reliably fail if ft isn't set.
> >
> > I will have to get a clean copy of trunk to apply the patch to (mine is
> full
> > of changes :-) but will do so as soon as possible if no one beats me to
> it.
>
> Oops, doc->file_type is never NULL now so I assumed ft never was.
>

Same here, but of course doc can be null dammit!


>
> BTW is a separate ft argument necessary if we have doc?
>

No, originally it didn't use doc just ft, evolving software...

Cheers
Lex

>
> Regards,
> Nick
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20100310/0b5793a1/attachment.html>