[Geany-devel] [PATCH 19/19] Use per document indent sizes

[Jiří Techet]

On Fri, Aug 6, 2010 at 04:15, Lex Trotman <elextr at gmail.com> wrote:
> On 6 August 2010 11:19, Erik de Castro Lopo <mle+tools at mega-nerd.com> wrote:
>> Jiří Techet wrote:
>>
>>>
>>> Different documents may use different indent size and it's often necessary
>>> to have all of them opened in parallel and use the correct indent size
>>> for each of them.
>>>
>>> The current implementation doesn't save the indent size to the project and
>>> session file - this can be added if desired.
>>>
>>> Right now the indent size is set from a submenu of the document menu.
>>> This can be changed to use dialog to set the indent size; also a combined
>>> approach is possible - display only the common sizes in the submenu
>>> (2, 4, 8) with "others" item that opens the dialog to set the more esoteric
>>> indent sizes.
>>
>> I like this, but it uses gtk_menu_item_get_label() which according to
>> this:
>>
>>    http://library.gnome.org/devel/gtk/unstable/GtkMenuItem.html#gtk-menu-item-get-label
>>
>> arrived in Gtk 2.16. Currently the configure script accepts gtk >= 2.8.

Ah, thanks for noticing this - I build geany with the latest gtk and
usually forget to look at in which version the given function was
introduced.

>>
>> Cheers,
>> Erik
>> --
>
> It should be possible to use ui_menu_item_get_text from ui_utils instead.

Thanks for the hint - will post a corrected patch soon.

Jiri

>
> Cheers
> Lex
>
>> ----------------------------------------------------------------------
>> Erik de Castro Lopo
>> http://www.mega-nerd.com/
>> _______________________________________________
>> Geany-devel mailing list
>> Geany-devel at uvena.de
>> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>>
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>