[Geany-devel] Erlang support patch

[Enrico Tröger]

On Fri, 17 Jul 2009 01:07:42 +0200, Etienne wrote:

Hi,

>You'll find my patch to introduce Erlang support, made against SVN
>n3981, in attached file.

Cool, thanks.

>Please, can someone check this patch and maybe commit it?

It looks good so far.
Just a few questions/comments:

- some example files would be helpful because most of us probably don't
know Erlang (at least me)

- what about the Scintilla Erlang Lexer? The copyright notice in the
lexer in your patch states you wrote it? What's wrong with the Erlang
lexer available in Scintilla? Is it a different one? Is one the both
better? Why another one?

- when creating patches, the unified diff format is preferred (-u
option for the diff command) or even simpler use: 'svn diff'


Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20090718/9c739c87/attachment.pgp>