[Geany-devel] "Auto-close quotes and brackets" - addition request

[JGuillaume (ioguix) de Rorthais]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Happy New Year to you guys ! Best wish to you and Geany :)

In reply to this discussion on the geany list:
http://lists.uvena.de/pipermail/geany/2008-December/003878.html

I did my own version of the patch (in attachment). It still have
following some flaws:
- - when you insert an autoclosed char and immediatly delete it, the
non-autoclose code kicks in anyway (I'm not sure how/where to deal
with the delete keys)
- - when inserting a quote (double or not), coming back before it and
inserting another one, the non-autoclose code kicks in anyway. Should
we test the next-char before non-autoclosing ?
- - the test for matching bracket seems a bit too greedy as autoclose
often doesn't kicks in because of a closing bracket few lines after.

Hadn't notice any lag with this code, however I wasn't notice lag with
Enrico's patch neither...so someone with an older computer should
probably check that.

Thanks for your next answer and review :)
- --
Guillaume (ioguix) de Rorthais
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkllg9QACgkQxWGfaAgowiIFBgCfa4Wrn7gOUrwUarMMAbgxI+Yy
hVwAn1FWzNd8eQeXL0oApICzvTdKGRF6
=WD/5
-----END PGP SIGNATURE-----

-------------- next part --------------
A non-text attachment was scrubbed...
Name: skip_autoclose_chars_when_closing.patch.gz
Type: application/gzip
Size: 1511 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20090107/36fc018d/attachment.bin>