[Geany-devel] ANN: Configurable build beta in trunk

Lex Trotman elextr at xxxxx
Wed Aug 26 05:09:44 UTC 2009

2009/8/26 Enrico Tröger <enrico.troeger at uvena.de>:
> On Tue, 25 Aug 2009 14:35:54 +1000, Lex wrote:
>>Hi All,
>>The configurable build system has been merged into the latest trunk
> And crashes Geany at startup under some circumstances :(.
> I happily updated my Geany at work this morning and once I started it,
> it crashed. http://nopaste.geany.org/p/m5ab611f0 has a short backtrace.
> Though I didn't manage to find the cause of this crash but I also
> hadn't much time to look into it.
> I zipped my .config/geany directory and tried to reproduce here at home
> but with no luck. So, I guess it might be related to the project I had
> opened, unfortunately I didn't copy the project file.
> Well, I'll try to debug this a bit more tomorrow.
> Lex, maybe you already have an idea what's wrong?
> I wonder what's about the variable i in the outer for loop, is it
> initialised at all?

No its not initialised, but it shouldn't be a variable i, S/B 1, see
attached patch.  Removes the now unused variable too.

> Additionally, I noticed the FOREACH_GEANYBUILDCMD_ENTRY () macro which,
> erm, looks weird. It defines an usual for loop which also uses a
> variable i. From my experience, I'd say such things can easily lead to
> weird errors and makes the code less readable.

The decision on macro or not is between you and Thomas, as a C++
programmer I lean towards the "macros are evil" (but occasionally
necessary) approach.
If the macro stays I suggest that the uses of the argument in the
macro body be enclosed in (), this is a standard way to reduce
problems in case arguments are expressions.

> Btw, I noticed lines 2362 and the following ones are indented with
> spaces which should be tabs :).

Fixed in patch also.  Is there a "convert all indents to Geany
standard" command?

Do you have a problem if I commit bugfixes to build.c and build.h in
trunk (I'll commit to no other files)?

> Regards,
> Enrico
> --
> Get my GPG key from http://www.uvena.de/pub.asc
> _______________________________________________
> Geany-devel mailing list
> Geany-devel at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build_patch.diff
Type: text/x-patch
Size: 1149 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20090826/de9ee75f/attachment.bin>

More information about the Devel mailing list