[Geany-devel] sciwrappers.h not compilable ?

[Colomban Wendling]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Enrico Tröger wrote:
> About your initial question abut including sciwrappers.h: the order
> of header includes is important, I think I already told you that in
> another thread. First include geany.h, then other Geany includes
> like document.c or sciwrappers.h, then include pluginmacros.h and
> geanyfunctions.h. You can't include headers randomly. See other
> plugins how they do it.
>
> All stuff Colomban explained with PLAT_GTK and ScintillaObject
> declaration is not true as long as you include geany.h. That does
> all the necessary stuff for you. Check this file to get a clue.
Just for my self curiousity about including order: why does it is
required?
I'm a partisan of the "include all you need, but no more" style,
meaning that if I use a symbol, I have to include what defines it.
e.g. for sciwrappers.h, I would include glib.h as it uses GLib types
and define or include something that defines PLAT_GTK. I don't see any
reason why not doing this, and I think it is better for each code part
to be self-sufficient.
Then the question: why it is done this way?

Thomas Martitz wrote:
> A way to work around at least is to add some #warning (or even
> #error), like […]
#warning is a GCC (and perhaps others) extension, prefer #error for
general cases ;)


Regards,
Colomban
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqIZyAACgkQyqbACDEjVWjIsACeMTtrDyqHv1Eg6WUrHcbJ1FEC
4B0AoKM8ekn3fA4/PQ4XCODUeJc+08BM
=OSzy
-----END PGP SIGNATURE-----