This is to mitigate this change in Scintilla 5.1.5:
> When calling SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE with a NULL buffer argument to discover the length that should be allocated, do not include the terminating NUL in the returned value. The value returned is 1 less than previous versions of Scintilla. Applications should allocate a buffer 1 more than this to accommodate the NUL. The wParam (length) argument to SCI_GETTEXT and SCI_GETCURLINE also omits the NUL. This is more consistent with other APIs.
While it doesn't prevent simple recompilation of existing plugins without fixing the possible problems in them, at least it doesn't allow users using binary releases to load old, unfixed plugins. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3541
-- Commit Summary --
* Bump Geany ABI to mitigate Scintilla 5.1.5 changes
-- File Changes --
M src/plugindata.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/3541.patch https://github.com/geany/geany/pull/3541.diff
Agreed, its not a perfect solution, but its better than nothing. LGTM.
Agreed. Let's merge.
Merged #3541 into master.
github-comments@lists.geany.org