See Scintilla release notes here
https://www.scintilla.org/ScintillaHistory.html
and https://github.com/geany/geany/issues/3095 You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1154
-- Commit Summary --
* geanypg: Update to Scintilla 5.1.5 SCI_GETSELTEXT change
-- File Changes --
M geanypg/src/helper_functions.c (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1154.patch https://github.com/geany/geany-plugins/pull/1154.diff
@techee pushed 1 commit.
ce32fe287810c38dda048b0b46a3dbf122e75b81 geanypg: bump API for the Scintilla 5.1.5 change
Should not use send message directly, should use `sci_get_selection_contents()`
@techee pushed 1 commit.
b8d8689f315f6b7c464de1d2ae90aeeba7758d1e geanypg: Update because of Scintilla 5.1.5 SCI_GETSELTEXT change
Should not use send message directly, should use sci_get_selection_contents()
Good point, then it doesn't need the API bump change.
But I think we should actually do ABI bump because the previous version won't work correctly, what do you think?
But I think we should actually do ABI bump because the previous version won't work correctly, what do you think?
Well thats part of Geany, and discussions elsewhere, not this PR, and as @kugel- pointed out elsewhere that won't help if the plugin gets re-compiled, but its better than nothing.
LGTM
@kugel- approved this pull request.
@techee pushed 1 commit.
01cdc19725cd8acfd88b1d486394ad8b50be8a5c geanypg: Update because of Scintilla 5.1.5 SCI_GETSELTEXT change
@techee pushed 1 commit.
52f3884823b247288f53fce00f1f0e27ed8a87fb geanypg: Update because of Scintilla 5.1.5 SCI_GETSELTEXT change
I'm merging this as I think the patch is OK - it should be the last piece of the Scintilla 5.1.5 aftermath.
Merged #1154 into master.
github-comments@lists.geany.org