@liomarhora pushed 1 commit.

965704e6063c3bf806cfa6e0705cfc1f43ac9283 update of the files that make the devhelp-plugin be added to the geany IDE.

@liomarhora pushed 1 commit.

28da94209c03d0558c2efd4200cfc63d5e4dd85f devhelp-plugin working

Fails on Linux. Please remove all build artifacts from the PR.

What would that be?

@liomarhora pushed 1 commit.

3d055fa1066fe984a600059bd81d0e52a593e6fe library old and files some build artifacts deleted

What have you done to move the plugin to a supported version of webkit? It was deleted from geany-plugins because it used a version of webkit that was not supported by most distributions and nobody wanted to port it to the new version because IIUC the API changed significantly.

What have you done to move the plugin to a supported version of webkit? It was deleted from geany-plugins because it used a version of webkit that was not supported by most distributions and nobody wanted to port it to the new version because IIUC the API changed significantly.

I analyzed the functions of the new webkit and migrated. The same was done with libdevhelp. There is little left to port from gtk to version 3, but it is functional

Neither Linux nor Windows CI passes, that needs to be fixed.

Por que você está construindo o libdevhelp a partir de uma fonte estática em vez de usar o libdevhelp distribuído pela distro que é compatível com atualizações de segurança, correções de bugs, etc?

Why are you building libdevhelp from a static source instead of using the libdevhelp distributed by the distro that is supported with security updates bugfixes etc?

apologies for the delay. I had an unforeseen event and could only respond now. I am building with the library provided by the system (Debian). But where are you checking the static font in the code?

I accidentally closed the pull.

Neither Linux nor Windows CI passes, that needs to be fixed.

How do I perform these tests before pulling? Why is it working normally on debian and manjaro.

If you are using the library then remove the devhelp sources from the pull.

The CI runs on Ubuntu 20.04

[Edit: the dependency you ask for is the old version of webkit that is no longer available, so the CI doesn't even start]

I believe I found the place where I requested the old version of webkit.

@liomarhora pushed 1 commit.

820c1da737abec7b40f6aa3b152bccb74043429f replacing gtk_tool_button_new_from_stock with gtk_tool_button_new on zoom buttons and page forward and back buttons

Nup, you still tell CI to load libwebkitgtk-dev which does not exist any more.

Its not in the code its in the CI setup, `build.yml`, the CI hasn't even gotten to compiling your code yet.

The Windows build doesn't fail (it uses a docker image with pre-installed deps), but devhelp does not configure, possibly because that image doesn't have the requisite dependencies.

Maybe because of webkit, @eht16 is there a even a webkit for windows? Webhelper doesn't configure on windows either.

Nup, you still tell CI to load libwebkitgtk-dev which does not exist any more.

Its not in the code its in the CI setup, `build.yml`, the CI hasn't even gotten to compiling your code yet.

The Windows build doesn't fail (it uses a docker image with pre-installed deps), but devhelp does not configure, possibly because that image doesn't have the requisite dependencies.

Maybe because of webkitgtk, @eht16 is there a even a webkitgtk for windows? Webhelper doesn't configure on windows either.

how do i solve this?

Its not in the code its in the CI setup, build.yml, the CI hasn't even gotten to compiling your code yet.

That by editing your changes to `build.yaml` to ask for the correct version.

Windows, forget it, to answer my own question to @eht16 above, google can't find webkitgtk for windows, so it probably doesn't exist.

(/me slips into grumpy olde guy mode) How is `build.yaml` `devhelp.m4`?

For me `build.yaml` comes up as the very first change on the "Files Changed" tab of the PR on github.

The Windows build doesn't fail (it uses a docker image with pre-installed deps), but devhelp does not configure, possibly because that image doesn't have the requisite dependencies.

The Docker image is not really relevant here, it only has some dependencies as some sort of cache. The workflow definition in the project is the authority for installing dependecies.

Maybe because of webkit, @eht16 is there a even a webkit for windows? Webhelper doesn't configure on windows either.

There is no more WebkitGTK for Windows: ***@***.***/thread/4DEVGI2ICZX7F7GE6FLSNNQF3Q6I2OP7/

The link in the post is broken, the correct one should be https://github.com/MSYS2/MINGW-packages/issues/4318.

So, the devhelp plugin won't be available on Windows at all.

@liomarhora pushed 1 commit.

48c67e811e693cc75e1d1be2d11225aa0355d59e Update build.yml

ok, since the windows CI properly configures devhelp disabled there is nothing to do there.

So @liomarhora [this](.github/workflows/build.yml) just needs to depend on a current package, possibly libwebkit2gtk-4.0-dev (what is installed here on old Mint). Then the CI should get to your code, as its working that should go smoothly :-).

updated version of webkitgtk library in CI. Could you run the test?

Ahhh, now both Linux and Windows break, the `devhelp.m4` should explicitly disable on windows since the libwebkit2 is available on the cross compile host platform and that is what configure tests. I am m4 illiterate, maybe some expert can advise how.

@liomarhora Linux fail means you have a dependency on something else which you happen to have installed on your machine but which isn't on the CI machine, no idea what.

Is there a way to run the app on the CI of my fork before pulling it on the master?

@liomarhora pushed 1 commit.

d8fcca72d6108b0de0b323b077f57a1d93f28402 Update build.yml

@liomarhora pushed 2 commits.

6a784e271cf0b6e086da93e4a5ba2f9dbd315b48 changing webkit library in build.yml file and changing maintainer name in devhelp/README file c063cec40bc706a0531c9dc4c08735a40e9ee29b changing webkit library in devhelp.m4

@liomarhora pushed 1 commit.

ec67c88829a9d3721a372a4a5f3cfbbac574d596 Update devhelp.m4

...

Is there a way to run the app on the CI of my fork before pulling it on the master?

Possibly, but I don't know how, possibly a github expert can tell what needs to be enabled.

...

Is there a way to run the app on the CI of my fork before pulling it on the master?

Possibly, but I don't know how, possibly a github expert can tell what needs to be enabled.

hello, I created a repository and did the tests in the CI and managed to fix the problem. I've updated the current repository and I'm waiting for it to run on CI. Could you perform this action for me?

there was in the POTFILES.in file the path of the old devhelp library. But I already made the changes.

@liomarhora pushed 1 commit.

89b358b9720dc03bb2f7eb14c0e7425963b310e1 Update configure.ac

Hello, Could take action now

You need to remove all the product files that have been committed. Anything that matches the patterns in geany-plugins `.gitignore`.

Manually with `git-rm`. Then do __not__ build until after committing the removal.

there were 23 commits, so I ran git reset --soft HEAD~22 and deleted 96 files. Was that the procedure?

there were 23 commits, so I ran git reset --soft HEAD~22 and deleted 96 files. Was that the procedure?

This removed the commits only for you locally, they are still here in the repository. Just the delete (`git rm` as @elextr said) the files mentioned in one of my comments above.

hello, I created a repository and did the tests in the CI and managed to fix the problem. I've updated the current repository and I'm waiting for it to run on CI. Could you perform this action for me?

I just approved the CI pipeline, so further pushes will be checked automatically.

@liomarhora commented on this pull request.

+}

+ + +/* Load module */ +G_MODULE_EXPORT +void geany_load_module(GeanyPlugin *plugin) +{ + /* Setup translation */ + main_locale_init(LOCALEDIR, GETTEXT_PACKAGE); + + /* Set metadata */ + plugin->info->name = _("Devhelp Plugin"); + plugin->info->description = _("Adds support for looking up documentation in Devhelp, manual pages, and " + "Google Code Search in the integrated viewer."); + plugin->info->version = "1.0"; + plugin->info->author = "Matthew Brush mbrush@leftclick.ca";

Updated.

@liomarhora pushed 1 commit.

555b502e13cbc3bdf5741e58fbfd932f3b5fbf2a Update AUTHORS

@liomarhora pushed 1 commit.

0c8bf0686fd1be9caebaa63341618a225ca17258 Update dhp-plugin.c

@liomarhora pushed 1 commit.

ed639b97b9e852b06c5d94ef0265fb2e992b4f87 Update dhp-object.c

@liomarhora pushed 1 commit.

4ba460d96bd8e7fb8c67cb8d03284cc55808bd92 Update dhp-object.c

@liomarhora pushed 1 commit.

67a8dfc185b732d17849b58fd2c8d72066ddac80 Update dhp-settings.c

@liomarhora pushed 1 commit.

7b1fa6f372ef3d4829bf05473f29a947537702e2 unnecessary files deleted

@liomarhorao problema é que você havia confirmado alguns desses arquivos de construção em sua ramificação, talvez você os tenha adicionado à força. Como@eht16disse que eles precisam ser removidos de lá, não apenas do diretório de trabalho, não queremos seus artefatos de construção específicos no repositório.

possivelmente `git-ls-files -i --exclude-standard`irá listá-los [conselho não experimentado]

Right. Understood

...

Fiz as modificações. Qual é o próximo passo?

Seja um pouco mais paciente até que alguém faça uma revisão completa. Eu gostaria, mas não posso dizer quando encontrarei tempo para fazê-lo.

All good. I'm new with programming. I thank you for your patience.

@liomarhora pushed 1 commit.

404b05701d2bcb7cee0c19f3eee38e23acd15e56 Update translation pt_BR.po

Hi, While the plugin was not accepted, I'm working on it. I made some changes regarding Zoom.

@liomarhora pushed 1 commit.

8b9bfccaa220ce25eda4854bded15a3ee468fabd Merge branch 'geany:master' into devhelpplugin

Closed #1242.