Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@eht16 requested changes on this pull request.
I had a quick look and left a few comments.
Though this was no proper review, just a first look.
In devhelp/AUTHORS:
> @@ -0,0 +1 @@ +Matthew Brush <mbrush@codebrainz.ca>
Maybe add yourself here?
> +}
+
+
+/* Load module */
+G_MODULE_EXPORT
+void geany_load_module(GeanyPlugin *plugin)
+{
+ /* Setup translation */
+ main_locale_init(LOCALEDIR, GETTEXT_PACKAGE);
+
+ /* Set metadata */
+ plugin->info->name = _("Devhelp Plugin");
+ plugin->info->description = _("Adds support for looking up documentation in Devhelp, manual pages, and "
+ "Google Code Search in the integrated viewer.");
+ plugin->info->version = "1.0";
+ plugin->info->author = "Matthew Brush <mbrush@leftclick.ca>";
Maybe add yourself here too?
In devhelp/src/dhp-manpages.c:
> @@ -0,0 +1,240 @@ +#include <stdlib.h>
Could you add the file header with the authors and license in all source files?
> @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.auxfiles.mk + +if GP_GTK3
What's the use of this switch? :D
> @@ -0,0 +1,6 @@ +#!/bin/sh
The files:
> @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.docs.mk + +plugin = devhelp + +dist_plugindata_DATA = \ + devhelp-plugin.svg \ + devhelp-plugin-48.png \ + geany-devhelp-plugin.png \
geany-devhelp.png is missing here or it is not used and can be removed?
> @@ -0,0 +1,1630 @@ +# Doxyfile 1.7.1
Is this file used anywhere?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.