In the status bar "None" have big N and "unknown" have small n. I'm guessing they should use the same style.
Windows 7. Geany 2.0. "Pryce" (bygget Oct 19 2023 eller efter) Med afviklingsbibliotekerne GTK+ v3.24.39 og GLib v2.78.0
Hmmm, `scope:` normally shows the name of the enclosing scope stack or if outside any scope it shows `unknown`. But `unknown` or `Unknown` are both valid values of scopes. Perhaps it should show something that is less commonly[^1] a valid scope, perhaps `-` @techee?
[^1]: many/most languages will see `-` as a minus operator, not valid for a scope, but there is always at least one outlier, I'm looking at you Lisp :grin:
Perhaps it should show something that is less commonly[1](https://github.com/geany/geany/issues/3632#user-content-fn-1-6f42eafda92f763...) a valid scope, perhaps - @techee?
Can be. (I personally don't care much as I use Geany with hidden statusbar.)
Where is "unknown" set? I pinged you on the assumption it was deep in the bowels of tagmanager?
Where is "unknown" set? I pinged you on the assumption it was deep in the bowels of tagmanager?
It's outside the tag manager:
https://github.com/geany/geany/blob/fefef55569424b72e540bafa4bec514e7e2fd6f5...
Probably the first two hits: ``` src/symbols.c:1947: *tagname = g_strdup(_("unknown")); src/symbols.c:1963: cur_tag = g_strdup(_("unknown")); src/ui_utils.c:286: doc->encoding ? doc->encoding : _("unknown")); ``` The third hit shows that we probably have the same issue for the encoding name in the statusbar (not tested yet but seems so).
I don't have a strong opinion on this but e.g. for encodings we always use title case for known encodings, so there an upper case "Unknown" would be appropriate and then we could also change it for scope.
Damn, I was following the functions from `ui_utils.c::create_statusbar_statistics()` and was only one function call away when I gave up :-)
So both the first two need to be changed (and kept the same into the future)?
I don't think "unknown" is likely to be confused with the name of a real encoding, so its only the uppercase U question. I thought all encoding names were all caps, so they will conflict with title case as well.
Damn, I was following the functions from `ui_utils.c::create_statusbar_statistics()` and was only one function call away when I gave up :-)
`git grep` is your friend :).
So both the first two need to be changed (and kept the same into the future)?
Yes, we could use a constant, easy.
I don't think "unknown" is likely to be confused with the name of a real encoding, so its only the uppercase U question. I thought all encoding names were all caps, so they will conflict with title case as well.
I'm not sure I understand this: how should the suggested encoding name "Unknown"conflict with "UTF-8" or "EUC-JP"?
how should the suggested encoding name "Unknown"conflict with "UTF-8" or "EUC-JP"?
when I mistype "UNlikely" :-D
You won't, I'm sure :).
I don't think "unknown" is likely to be confused with the name of a real encoding,
No wait, "likely" is correct, not "unlikely". The point I was just making is it will NOT be confused, unlike [scope](https://github.com/geany/geany/issues/3632#issuecomment-1773950714) where "unknown" is a possible valid scope name.
But the OP was about inconsistencies in casing, and "Unknown" is different to "UTF-8" or "EUC-JP", should it be "UNKNOWN"? Uggg, having typed that, its ugly, no "Unknown" will have to do.
No wait, "likely" is correct, not "unlikely". The point I was just making
Ok, good. Now I got it and also your ammendment "when I mistype "UNlikely" which I got initally wrong.
But the OP was about inconsistencies in casing, and "Unknown" is different to "UTF-8" or "EUC-JP", should it be "UNKNOWN"? Uggg, having typed that, its ugly, no "Unknown" will have to do.
Yes, "UNKNOWN" is not better than "unknown", probably rather worse. I would prepare a PR to change both to "Unknown".
@scootergrisen do you agree?
github-comments@lists.geany.org