`dialogs_show_input_full` had grown into a monster taking 2 different sets of callbacks. The complexity can be removed if: * the caller creates the combo/entry widget, as they can then connect any special signals to it themselves. * the caller runs the dialog even when modal
I was also tempted to remove the callback for `dialogs_show_input_persistent`, but I haven't done that here. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3826
-- Commit Summary --
* [Input Dialog refactor] Replace 5 parameters with 1 * Add entry parameter for flexibility * Also wrap label for dialogs_show_input_numeric
-- File Changes --
M src/dialogs.c (113)
-- Patch Links --
https://github.com/geany/geany/pull/3826.patch https://github.com/geany/geany/pull/3826.diff
@elextr approved this pull request.
Agree its a better idea to put the common parts in the shared function and the different parts in the callers.
Not tested but LGBI.
github-comments@lists.geany.org