dialogs_show_input_full had grown into a monster taking 2 different sets of callbacks.
The complexity can be removed if:

the caller creates the combo/entry widget, as they can then connect any special signals to it themselves.
the caller runs the dialog even when modal

I was also tempted to remove the callback for dialogs_show_input_persistent, but I haven't done that here.

You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany/pull/3826

Commit Summary

3b0bf7e [Input Dialog refactor] Replace 5 parameters with 1
d3a8c86 Add entry parameter for flexibility
f10afe7 Also wrap label for dialogs_show_input_numeric

File Changes

(1 file)

M src/dialogs.c (113)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.