[geany/geany] Translation message catalogs are always updated when building Geany (Issue #3077)

List overview All Threads

newer

older

[geany/geany] Switch autreconf...

[geany/geany-plugins] GeanyLua:...

Enrico Tröger

1 Jan 2022 1 Jan '22

12:40 p.m.

Since https://github.com/geany/geany/pull/2938 was merged, a simple `make` in the Geany source directory causes all `po/*.po` files to be updated and so listed as modified by `git status`.

@kugel- is this intended?

If there is no reason to do this, I'd consider this as rather annoying.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077@github.com

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

elextr

2 Jan 2 Jan

2:33 a.m.

And just running `autogen.sh` makes git think `INSTALL` is modified.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1003648671 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1003648671@github.com

elextr

2:57 a.m.

@kugel- please fix quickly or please revert #2938 (if its the cause) until you get time. Its too risky to commit things that were not intended.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1003650709 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1003650709@github.com

Robert Di Pardo

8:23 a.m.

https://github.com/geany/geany/blob/63a60f6ad799ebaac511e0ab3d251a44ff6c0061...

The `--force` option gets propagated down the toolchain:

~~~sh-session $ autoreconf --install --verbose --force autoreconf: Entering directory `.' autoreconf: running: autopoint --force autoreconf: running: aclocal --force -I m4 [ . . .] autoreconf: running: libtoolize --copy --force [ . . .] autoreconf: running: /usr/bin/autoconf --force [ . . .] autoreconf: running: /usr/bin/autoheader --force [ . . .] autoreconf: running: automake --add-missing --copy --force-missing [ . . .] ~~~

...

And just running `autogen.sh` makes git think `INSTALL` is modified.

That's because of `automake . . . `; run it without `--force-missing` and nothing gets modified.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1003674853 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1003674853@github.com

elextr

8:37 a.m.

Ok, so no `--force` and IIUC also should be `strictness` == `foreign`, Geany is not GNU package.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1003675911 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1003675911@github.com

David Yang

8 Jan 8 Jan

11:32 p.m.

Here because I was informed that the quick patch to the gitignore was misguided, tested and can confirm that `autoreconf --force-missing --install --verbose` mostly resolves this, leaving just a single file stamp-po created which we could just rm at the end of autogen or gitignore. I'm skimming the PR queue and don't see anything along these lines, can make it later when I'm more awake

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1008165940 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1008165940@github.com

Thomas Martitz

9 Jan 9 Jan

12:10 a.m.

Regarding the .po files

This seems to work. With this, manual `make -C po update-po` is needed.

```diff diff --git a/po/Makevars b/po/Makevars index 0877b1091..6525eb355 100644 --- a/po/Makevars +++ b/po/Makevars @@ -73,7 +73,7 @@ MSGINIT_OPTIONS = # has changed. Possible values are "yes" and "no". Set this to no if # the POT file is checked in the repository and the version control # program ignores timestamps. -PO_DEPENDS_ON_POT = yes +PO_DEPENDS_ON_POT = no

# This tells whether or not to forcibly update $(DOMAIN).pot and # regenerate PO files on "make dist". Possible values are "yes" and ```

Regarding `INSTALL`, I think it might have to do with the Automake version installed on the system. On my system INSTALL is not updated.

I'm trying to remember if the `--force` option was required for something but I can't. I guess we can drop it and see.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1008175507 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1008175507@github.com

David Yang

4:37 a.m.

Made the PR with --force-missing approach at first and looks like CI didn't like it, so reformed PR to switch PO_DEPENDS_ON_POT instead

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1008222617 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1008222617@github.com

elextr

5:19 a.m.

@kugel- this is the git diff for INSTALL

``` diff --git a/INSTALL b/INSTALL index e82fd21d..8865734f 100644 --- a/INSTALL +++ b/INSTALL @@ -1,8 +1,8 @@ Installation Instructions *************************

Copying and distribution of this file, with or without modification, are permitted in any medium without royalty provided the copyright @@ -225,7 +225,7 @@ order to use an ANSI C compiler:

and if that doesn't work, install pre-built binaries of GCC for HP-UX.

- HP-UX 'make' updates targets which have the same timestamps as their + HP-UX 'make' updates targets which have the same time stamps as their prerequisites, which makes it generally unusable when shipped generated files such as 'configure' are involved. Use GNU 'make' instead.

```

automake -- version

``` automake (GNU automake) 1.16.1 ```

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1008227112 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1008227112@github.com

Robert Di Pardo

2:50 p.m.

#3089 works:

```sh-session $ find _build/ -type f -name *po _build/po/stamp-po ```

...

Regarding `INSTALL`, I think it might have to do with the Automake version installed on the system.

Confirmed:

```sh-session $ git ls-files -m INSTALL

$ automake --version automake (GNU automake) 1.16.1 Copyright (C) 2018 Free Software Foundation, Inc. License GPLv2+: GNU GPL version 2 or later https://gnu.org/licenses/gpl-2.0.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey tromey@redhat.com and Alexandre Duret-Lutz adl@gnu.org. ```

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#issuecomment-1008301948 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issues/3077/1008301948@github.com

Thomas Martitz

9:50 p.m.

Closed #3077 via #3089.

-- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3077#event-5862746506 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/issue/3077/issue_event/5862746506@github.com

904

Age (days ago)

912

Last active (days ago)

github-comments@lists.geany.org

10 comments

5 participants

tags (0)

participants (5)

David Yang
elextr
Enrico Tröger
Robert Di Pardo
Thomas Martitz