**Before upgrade**
Geany 1.32, GTK 2.24.32, GLib 2.54.3 geany-1.32.0-1-x86_64.pkg.tar.xz, geany-plugins-1.32-2-x86_64.pkg.tar.xz Arch Linux, Theme: BlueMenta
Plugin "Lua Script" `geany.choose("Snippets:", {"bla", "bla", "bla"})` http://geany-plugins.sourceforge.net/geanylua/geanylua-ref.html#select
![Screenshot1:](https://s10.postimg.org/tbkoqhvex/Screenshot_2018-02-09_17-41-25.png)
**After upgrade**
Geany 1.32, GTK 3.22.26, GLib 2.54.3 geany-1.32.0-2-x86_64.pkg.tar.xz, geany-plugins-1.32-4-x86_64.pkg.tar.xz
![Screenshot2:](https://s10.postimg.org/h9pawejmh/Screenshot_2018-02-09_17-42-16.png)
GTK+ 3.22 broke all themes again, try an up to date theme like Adwaita or other popular one that has been fixed since.
GTK2 vs. GTK3: ![geany choose](https://user-images.githubusercontent.com/6333198/98442970-c5236280-2121-11e...) Xubuntu 20.04, Geany 1.37, GTK 3.24.20, GLib 2.64.3.
Is this the same problem? I tried Adwaita, Greybird (my default theme), Numix, but with the same result. Is this exactly a theme problem? Maybe someone know, how to fix it?
Doesn't look like a theme problem from @Skif-off's screenshots (I can't see the first one from the OP BTW), looks like incorrect widget packing with GTK3's defaults.
@Skif-off try: ```diff diff --git a/geanylua/glspi_dlg.c b/geanylua/glspi_dlg.c index f0553853..c7d9718a 100644 --- a/geanylua/glspi_dlg.c +++ b/geanylua/glspi_dlg.c @@ -163,10 +163,14 @@ static gint glspi_choose(lua_State* L) scroll=gtk_scrolled_window_new(NULL, NULL); gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scroll), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC); + gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW (scroll), GTK_SHADOW_IN); gtk_container_add(GTK_CONTAINER(gtk_dialog_get_content_area(GTK_DIALOG(dialog))),scroll); +#if GTK_CHECK_VERSION(3, 0, 0) + gtk_widget_set_vexpand(scroll, TRUE); +#endif gtk_container_add(GTK_CONTAINER(scroll),tree);
- gtk_widget_set_size_request(tree, 320, 240); + gtk_widget_set_size_request(scroll, 320, 240); gtk_widget_show_all(dialog); gtk_window_set_resizable(GTK_WINDOW(dialog), TRUE);
```
(the shadow type is just me not liking the borderless scrolled view when there is no other widgets making a border)
However, I don't understand why you see a "missing image" image under GTK3.
@b4n , thanks, looks better: ![2020-11-08_14-40-13](https://user-images.githubusercontent.com/6333198/98463049-01ae9700-21d2-11e...)
However, I don't understand why you see a "missing image" image under GTK3.
Maybe problem [here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_dlg.c#L14): `GTK_MESSAGE_OTHER` (without icon) replaced by `GTK_MESSAGE_INFO` (with icon)?
Maybe problem [here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_dlg.c#L14): `GTK_MESSAGE_OTHER` (without icon) replaced by `GTK_MESSAGE_INFO` (with icon)?
Well, IIUC that just aliases `GTK_MESSAGE_OTHER` to `GTK_MESSAGE_INFO` on GTK < 2.10 (presumably because `GTK_MESSAGE_OTHER` is new in 2.10 or something like that?). Should not affect GTK 2.24 vs 3.x AFAICT.
What OS are you using? If it Debian or any non Ubuntu-based distribution then maybe this problem was born here https://salsa.debian.org/gnome-team/gtk3/-/tree/ubuntu/focal/debian/patches ?
Rebuilding for all GTK 3 packages only with patchs from Debian will stay last way of checking :)
I'm on Debian Buster :) I'm not totally sure which dialog you're showing, but for me e.g. the dialog examples and a couple other that display this kind of dialogs all come without an image at all.
I think `message-dialog-restore-traditional-look-on-unity.patch` creates a problem, because only this patch contains the words `GtkMessageDialog`, `GtkWidget`, `icon` and `image`. (By the way this bug exists in `geany.input()`'s window too.)
@b4n, will you add your patch to upstream?
Win10, 1.37 GTK**2** vs. 1.38 GTK**3**: ![gtk2vs3](https://user-images.githubusercontent.com/6333198/137074307-ba00b4f8-c071-46...) Simple script: ```lua geany.choose('Test:', {"one", "two", "three"}) ``` Xubuntu, GTK3 with vs. without @b4n 's patch: ![w/w](https://user-images.githubusercontent.com/6333198/137076272-938d6c70-dcd4-4e...)
This patch: https://github.com/geany/geany-plugins/issues/690#issuecomment-723503783 worked for me on Debian Bullseye. (I had to remove the two commented lines to get it to build.) Thank you!
github-comments@lists.geany.org