The suffix "el" is very common in the context of Lisp and Emacs (a Lisp interpreter). You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3130
-- Commit Summary --
* Add "el" as "Lisp" filetyp extension
-- File Changes --
M data/filetype_extensions.conf (2)
-- Patch Links --
https://github.com/geany/geany/pull/3130.patch https://github.com/geany/geany/pull/3130.diff
@elextr commented on this pull request.
@@ -47,7 +47,7 @@ JSON=*.json;
Julia=*.jl; Kotlin=*.kt;*.kts; LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux; -Lisp=*.lisp; +Lisp=*.lisp;*.el
ending semicolon?
@Codeberg-AsGithubAlternative-buhtz pushed 1 commit.
0dc98c50007c2ca59ec9adfddef011fe0d3e9560 Added semicolon
@Codeberg-AsGithubAlternative-buhtz commented on this pull request.
@@ -47,7 +47,7 @@ JSON=*.json;
Julia=*.jl; Kotlin=*.kt;*.kts; LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux; -Lisp=*.lisp; +Lisp=*.lisp;*.el
I am not familiar with GitHub (web) interface. As I see in the "Commits" section the semicolon is no added, right? But I can not see it here in the "Conversations".
Is it OK that way?
@elextr commented on this pull request.
@@ -47,7 +47,7 @@ JSON=*.json;
Julia=*.jl; Kotlin=*.kt;*.kts; LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux; -Lisp=*.lisp; +Lisp=*.lisp;*.el
But I can not see it here in the "Conversations".
Note the "outdated" above :smile:
The "Files Changed" tab shows the aggregate of all commits and is fine.
Note the semicolon is not required, but every other line has one, so better to be consistent to avoid questions about why.
@Codeberg-AsGithubAlternative-buhtz commented on this pull request.
@@ -47,7 +47,7 @@ JSON=*.json;
Julia=*.jl; Kotlin=*.kt;*.kts; LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux; -Lisp=*.lisp; +Lisp=*.lisp;*.el
Note the semicolon is not required, but every other line has one, so better to be consistent to avoid questions about why.
I agree with the goal to be consistent to avoid questions and wasting support resources. But I would vote for another approach to reach that goal. IMHO it is unusual (for the most users) to have line endings like this. That is why I "forgot" them first. I am not aware of a language/file-format/notation that ask for such line endings. I assume that other users/committers would forget them, too. Which would waste resources in reviewing such PR's.
Because of that and if you agree I would create a follow-up PR removing all line-ending semicolon.
Merged #3130 into master.
@eht16 commented on this pull request.
@@ -47,7 +47,7 @@ JSON=*.json;
Julia=*.jl; Kotlin=*.kt;*.kts; LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux; -Lisp=*.lisp; +Lisp=*.lisp;*.el
Because of that and if you agree I would create a follow-up PR removing all line-ending semicolon.
I suggest saving you and us the effort to create and discuss such a PR. IMO it is just not important if there are terminating line ending semi colons or not. Since they are there now, I'd say just keep it as it is and as it is also for probably most user configurations.
github-comments@lists.geany.org