@Codeberg-AsGithubAlternative-buhtz commented on this pull request.


In data/filetype_extensions.conf:

> @@ -47,7 +47,7 @@ JSON=*.json;
 Julia=*.jl;
 Kotlin=*.kt;*.kts;
 LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux;
-Lisp=*.lisp;
+Lisp=*.lisp;*.el

Note the semicolon is not required, but every other line has one, so better to be consistent to avoid questions about why.

I agree with the goal to be consistent to avoid questions and wasting support resources. But I would vote for another approach to reach that goal.
IMHO it is unusual (for the most users) to have line endings like this. That is why I "forgot" them first. I am not aware of a language/file-format/notation that ask for such line endings. I assume that other users/committers would forget them, too. Which would waste resources in reviewing such PR's.

Because of that and if you agree I would create a follow-up PR removing all line-ending semicolon.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3130/review/891054160@github.com>