Let's try to make cppcheck work again, and even report useful stuff.
During the journey it found a few actual issues, which is good. It also found some false-positives, which isn't so good.
We probably could reduce the false positives by not using `--library=gtk`, but that also would reduce the actual issues it can find.
There are a few issues that should be reported upstream, but it's harder than it looks… if I could only remember my password on their tracker :confused:
Anyway, what do you guys think? Is it good? Are there too many false-positives? Should the suppressions be moved back to `AM_CPPCHECKFLAG`s not to alter the code, although it makes it harder to maintain?
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1346
-- Commit Summary --
* cppcheck: Enable parallelism to match Make call
* cppcheck: Properly define GETTEXT_PACKAGE globally
* cppcheck: Undefine GEANY_PRIVATE
* cppcheck: Use cppcheck's own gtk support
* cppcheck: Define the common plugin defines to their actual values
* ci: Enable exhaustive cppcheck checking
* cppcheck: Enable inline suppression hints
* addons: Fix memory leak detected by cppcheck
* geanyprj: Fix memory leak detected by cppcheck
* workbench: Fix memory leak detected by cppcheck
* geniuspaste: Fix memory leak detected by cppcheck
* markdown: Slightly rewrite two tests for cppcheck's sake
* cppcheck: Add inline suppressions for false-positives
* Remove obsolete cppcheck suppressions
* treebrowser: Move cppcheck suppressions inline
-- File Changes --
M .github/workflows/build.yml (2)
M addons/src/ao_tasks.c (11)
M build/cppcheck-geany-plugins.cfg (4)
M build/cppcheck.mk (6)
M geanyctags/src/geanyctags.c (2)
M geanygendoc/src/ggd-options.c (1)
M geanyprj/src/Makefile.am (3)
M geanyprj/src/utils.c (3)
M geniuspaste/src/geniuspaste.c (5)
M git-changebar/src/gcb-plugin.c (1)
M markdown/src/conf.c (4)
M scope/src/Makefile.am (2)
M scope/src/debug.c (4)
M treebrowser/src/Makefile.am (3)
M treebrowser/src/treebrowser.c (2)
M vimode/src/cmd-runner.c (2)
M workbench/src/sidebar.c (6)
M workbench/src/wb_project.c (4)
M workbench/src/workbench.c (4)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1346.patchhttps://github.com/geany/geany-plugins/pull/1346.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1346
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1346(a)github.com>
Each object in the list is a file object, not a string:
`ctags_tests = files([...` hence the message:
"tests/meson.build:359: DEPRECATION: Project uses feature that was always broken, and is now deprecated since '1.3.0': str.format: Value other than strings, integers, bools, options, dictionaries and lists thereof..."
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3759
-- Commit Summary --
* Fix deprecation warning about str.format() during meson setup
-- File Changes --
M tests/meson.build (2)
-- Patch Links --
https://github.com/geany/geany/pull/3759.patchhttps://github.com/geany/geany/pull/3759.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3759(a)github.com>
Insert devhelp plugin
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1311
-- Commit Summary --
* Porting devhelp plugin for gtk3. Working display in sidebar and main window. Missing showing SearchBar in sidebar or other tweaks.
* update of the files that make the devhelp-plugin be added to the geany IDE.
* try add SearchBar
* devhelp-plugin working
* library old and files some build artifacts deleted
* editing build file devhelp.m4
* webkit change to new version
* Changing the devhelp plugin maintainer in the MAINTAIN file
* replacing gtk_tool_button_new_from_stock with gtk_tool_button_new on zoom buttons and page forward and back buttons
* modified webkitgtk dependency in devhelp.m4 file
* Update build.yml
* Update build.yml
* Update build.yml
* Update build.yml
* changing webkit library in build.yml file and changing maintainer name in devhelp/README file
* changing webkit library in devhelp.m4
* changing webkit library in README
* insert devhelp plugin
-- File Changes --
M .github/workflows/build.yml (5)
M MAINTAINERS (7)
M Makefile.am (4)
M README (1)
A build/devhelp.m4 (29)
M configure.ac (1)
A devhelp/AUTHORS (1)
A devhelp/COPYING (674)
A devhelp/ChangeLog (0)
A devhelp/INSTALL (365)
A devhelp/Makefile.am (10)
A devhelp/NEWS (16)
A devhelp/README (114)
A devhelp/autogen.sh (6)
A devhelp/config.status (1863)
A devhelp/configure (5620)
A devhelp/configure.ac (34)
A devhelp/configure.scan (29)
A devhelp/data/Makefile.am (10)
A devhelp/data/devhelp-plugin-48.png (0)
A devhelp/data/devhelp-plugin.svg (467)
A devhelp/data/devhelp.conf (67)
A devhelp/data/geany-devhelp-plugin.png (0)
A devhelp/data/geany-devhelp.png (0)
A devhelp/data/home.html (16)
A devhelp/doc/Doxyfile (1630)
A devhelp/libtool (11748)
A devhelp/m4/libtool.m4 (8394)
A devhelp/m4/ltoptions.m4 (437)
A devhelp/m4/ltsugar.m4 (124)
A devhelp/m4/ltversion.m4 (23)
A devhelp/m4/lt~obsolete.m4 (99)
A devhelp/src/Makefile.am (40)
A devhelp/src/dhp-manpages.c (240)
A devhelp/src/dhp-object.c (1405)
A devhelp/src/dhp-plugin.c (230)
A devhelp/src/dhp-plugin.h (35)
A devhelp/src/dhp-settings.c (349)
A devhelp/src/dhp.h (144)
M po/POTFILES.in (46)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1311.patchhttps://github.com/geany/geany-plugins/pull/1311.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1311
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1311(a)github.com>
This feature allows quick navigation do document/workspace symbols based on their names, open files, and line numbers.
The panel's code is mostly stolen from the LSP plugin which in turn stole it from the Colomban Wendling's Commander plugin.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1341
-- Commit Summary --
* projectorganizer: Add popup panel for navigation
-- File Changes --
M projectorganizer/README (6)
M projectorganizer/src/Makefile.am (6)
A projectorganizer/src/prjorg-goto-anywhere.c (332)
A projectorganizer/src/prjorg-goto-anywhere.h (28)
A projectorganizer/src/prjorg-goto-panel.c (496)
A projectorganizer/src/prjorg-goto-panel.h (59)
M projectorganizer/src/prjorg-menu.c (55)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1341.patchhttps://github.com/geany/geany-plugins/pull/1341.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1341
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1341(a)github.com>
Anyone had a try to see how much work it would be to adjust geany to gtk4?
Or optionally have it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2713
The location to place themes when Geany has been installed from flatpak is:
/var/lib/flatpak/app/org.geany.Geany/x86_64/stable/<stringofcharacters>/files/share/geany/colorschemes/
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/47
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-themes/issues/47(a)github.com>
Same as #1336 but using GIO instead of libsoup.
If wanted? CC @elextr @xiota @frlan.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1340
-- Commit Summary --
* updatechecker: Port to libsoup3
* updatechecker: Don't leak the libsoup session
* updatechecker: Avoid a deprecated call
* updatechecker: Remove weird German quotes
* updatechecker: Port from libsoup to plain GIO
-- File Changes --
M build/updatechecker.m4 (2)
M updatechecker/README (6)
M updatechecker/src/updatechecker.c (145)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1340.patchhttps://github.com/geany/geany-plugins/pull/1340.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1340(a)github.com>
Hoping this PR is quick to review and merge...
This moves info from ABOUT to README for the LaTeX plugin. This should make the [plugin page](https://plugins.geany.org/latex.html) more informative to potential users.
Also, deletes the ABOUT file from the latex, geanymacro, and geanynumberedbookmarks plugins because they duplicate the contents of README.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1343
-- Commit Summary --
* LaTeX: Improve readme
* Remove redundant ABOUT files
-- File Changes --
D geanymacro/ABOUT (44)
D geanynumberedbookmarks/ABOUT (62)
D latex/ABOUT (17)
M latex/README (33)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1343.patchhttps://github.com/geany/geany-plugins/pull/1343.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1343(a)github.com>