Each object in the list is a file object, not a string:
`ctags_tests = files([...` hence the message:
"tests/meson.build:359: DEPRECATION: Project uses feature that was always broken, and is now deprecated since '1.3.0': str.format: Value other than strings, integers, bools, options, dictionaries and lists thereof..." You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3759
-- Commit Summary --
* Fix deprecation warning about str.format() during meson setup
-- File Changes --
M tests/meson.build (2)
-- Patch Links --
https://github.com/geany/geany/pull/3759.patch https://github.com/geany/geany/pull/3759.diff
@andy5995 commented on this pull request.
@@ -355,7 +355,7 @@ ctags_tests = files([
runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test('@0@'.format(f[0][0]), runner,
Oops, that's not right. Let me have a closer look at how to do this right...
@andy5995 pushed 1 commit.
ad3e7753f9de9956e706aed00b784ee58e6bdff5 Fix deprecation warning about str.format() during meson setup
@andy5995 commented on this pull request.
runner = find_program('ctags/runner.sh')
foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner,
The required meson version is 0.53 and this feature is not available until 0.59
Looks like they've added full_path but that feature requires meson 1.4.1
https://stackoverflow.com/a/77647927/6838037
https://mesonbuild.com/Reference-manual_returned_file.html
https://github.com/mesonbuild/meson/issues/12259
Anyway, a pretty trivial issue. It works as-is. I assume you don't wanna set the required meson version to 0.59 yet. Feel free to close this PR unless you wanna discuss it further.
@andy5995 commented on this pull request.
runner = find_program('ctags/runner.sh')
foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner,
One other potentially noteworthy feature of 0.59 is that when using 'ninja uninstall`, the gmo/mo files get uninstalled as they should.
@andy5995 commented on this pull request.
runner = find_program('ctags/runner.sh')
foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner,
@eli-schwartz Isn't there a proper way to convert a file object to a string in <=0.53? (I suppose that's why the warning isn't a hard error, and the fs and full_path() features have been introduced).
@eli-schwartz commented on this pull request.
runner = find_program('ctags/runner.sh')
foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner,
You could start off with strings. :)
@andy5995 pushed 1 commit.
aab90a0d052ced3c6e2775688c2dcaaa153ffd83 Start off with strings
@b4n approved this pull request.
Looks good and works fine.
Could you please just squash the commits together? (or I can do it if you prefer)
@eht16 @b4n This is squashed and ready to go.
Merged #3759 into master.
github-comments@lists.geany.org