After the update to Scintilla 5.1.5, I started getting memory corruption crashes when saving some files. (Sorry for not noticing this before, I thought the Scintilla update didn't contain any changes on the Geany side.) I may be wrong but I think the problem is in
https://github.com/geany/geany/pull/3046/commits/d7c985e47412f8a53c5a8202a0…
and misunderstanding if the following Scintilla API change
>When calling SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE with a NULL buffer argument to discover the length that should be allocated, do not include the terminating NUL in the returned value. The value returned is 1 less than previous versions of Scintilla. Applications should allocate a buffer 1 more than this to accommodate the NUL. The wParam (length) argument to SCI_GETTEXT and SCI_GETCURLINE also omits the NUL. This is more consistent with other APIs.
This part
>When calling SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE with a NULL buffer argument to discover the length that should be allocated, do not include the terminating NUL in the returned value...
> ...The wParam (length) argument to SCI_GETTEXT and SCI_GETCURLINE also omits the NUL.
says that that the returned __length__ doesn't include NUL, not that the returned string misses the NUL character. The rest of the change description says that we should allocate `+1` buffer to accommodate for that.
I believe we should revert the above patch and then go through all the uses of `SCI_GETTEXT`, `SCI_GETSELTEXT`, and `SCI_GETCURLINE` and corresponding `sci_` wrappers and update the code where needed (including plugins). I don't think it's a good idea to update the `sci_` wrappers alone to mirror previous behavior since the whole Scintilla API is part of Geany's API so this is a API change anyway and making `sci_` functions do something else than direct Scintilla calls is confusing.
Rant: I really don't understand why Neil made this change - even though it fixes some inconsistency in Scintilla API, this is a hard to spot backwards incompatible change and such things shouldn't be made in minor releases of a library.
@kugel- @eht16 @elextr What do you think?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3095(a)github.com>
This is to mitigate this change in Scintilla 5.1.5:
> When calling SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE with a NULL buffer argument to discover the length that should be allocated, do not include the terminating NUL in the returned value. The value returned is 1 less than previous versions of Scintilla. Applications should allocate a buffer 1 more than this to accommodate the NUL. The wParam (length) argument to SCI_GETTEXT and SCI_GETCURLINE also omits the NUL. This is more consistent with other APIs.
While it doesn't prevent simple recompilation of existing plugins without fixing the possible problems in them, at least it doesn't allow users using binary releases to load old, unfixed plugins.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3541
-- Commit Summary --
* Bump Geany ABI to mitigate Scintilla 5.1.5 changes
-- File Changes --
M src/plugindata.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/3541.patchhttps://github.com/geany/geany/pull/3541.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3541
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3541(a)github.com>
Unless I am wrong, should not "%Y-%m-%d" be the first of the formats offered and not as a special format.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3556
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3556(a)github.com>
Would it be possible to group the color themes into "light" and "dark"? Either as two columns in the theme selector or as two sections in the list.
Background: Lately I've been getting irritated eyes frequently and was suggested that this may be due to staring at a bright screen for extended periods of time, so (in addition to adjusting the brightness) I decided to give dark themes a try, since I heard they are less harmful for your eyes (not sure how scientific this is, but trying won't hurt...)
Problem is, it was hard to compare dark themes by going through the list with arrow keys, because light and dark are interleaved, and whenever I hit a light theme my eyes would readjust and forget if the previous dark theme was better or worse than the next.
So I think being able to browse only light or only dark themes would make the choice easier.
(This leaves open the question: "how do you decide if a theme is light or dark automatically?" -- I guess probably looking at the default background and foreground colors, but comparing color brightness is a bit tricky...)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3566
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3566(a)github.com>
Hi,
i am using Debian 12 and Geany 1.38 for Python 3 programming. I use Cinnamon Desktop; However the issue persists in both Cinnamon and GNOME Desktop environments.
1. Set build Commands:
a) "Compile" is set to: **python3 -m py_compile "%f"**
b) "Execute" is set to: **python3 "%f"**
c) "Make", Make Custom Target each set to: **make**
d) "Make Object" is set to: **make %e.o**
2. Edit --> Preferences -->Tools:
a) Terminal is set to: **x-terminal-emulator -e "/bin/sh %c"**
b) Browser is set to: **sensible-browser**
c) Grep is set to: grep
**Issue**:on hitting F5 to execute/run code results in a terminal window popup launching and disappearing almost instantly. Will appreciate help with resolving the issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3567
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3567(a)github.com>
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3565
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3565(a)github.com>
Instead of requiring the user to specify a browser just try to
use the system default browser through gtk_show_uri_on_window().
This is done when tool_prefs.browser_cmd is empty which is
also the new default.
This aligns with windows where we do this already. Though we're
bypassing tool_prefs.browser_cmd there entirely, while on non-Windows
we still honor tool_prefs.browser_cmd when it's set.
This is primarily useful for flatpak support where we cannot just
execute arbitrary commands on the host (unless using flatpak-spawn).
Also, firefox is arguably a bad default these days, given the
declined marked share.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3178
-- Commit Summary --
* Use gtk_show_uri_on_window() in utils_open_browser() by default
-- File Changes --
M data/geany.glade (1)
M src/keyfile.c (4)
M src/utils.c (18)
-- Patch Links --
https://github.com/geany/geany/pull/3178.patchhttps://github.com/geany/geany/pull/3178.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3178(a)github.com>
This adds a new option in the preferences dialog to show line ending characters only when they differ from what the majority of the line endings in the file use.
So it should be easier to spot accidentally misused line endings.
The idea is from @cousteaulecommandant and shamelessly implemented by me :D.
I guess we can improve the wording of the visible option name and its tooltip.
Screenshot:
Testfile: [show_differing_eols.zip](https://github.com/geany/geany/files/9542533/show_…
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3287
-- Commit Summary --
* Add option to only show line endings if they differ from file default
-- File Changes --
M data/geany.glade (52)
M doc/geany.txt (40)
M src/editor.c (1)
M src/editor.h (1)
M src/keyfile.c (2)
M src/plugindata.h (2)
M src/prefs.c (19)
M src/sciwrappers.c (25)
M src/sciwrappers.h (1)
-- Patch Links --
https://github.com/geany/geany/pull/3287.patchhttps://github.com/geany/geany/pull/3287.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3287
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3287(a)github.com>