Closed #1221.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#event-8723027077
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/issue_event/8723027077(a)github.com>
@asifamin13 pushed 1 commit.
7cd6454107f45540a1f62f4d471d78fecdd9583c Bracketcolors v1 codereview 3/10/23 (#3)
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/0850594b6132956e8a81…
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/push/12902959173(a)github.com>
@asifamin13 commented on this pull request.
> + static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+----------------------------------------------------------------------------- */
+{
+ return sci_get_char_at(sci, pos);
+}
When I was writing this, I was using the `autoclose` plugin as a template [which has this wrapper as well](https://github.com/geany/geany-plugins/blob/dc6980e5df24434597b37a5a7…. I suspect the authors of `autoclose` used the wrapper for convenience since it's used a lot, I don't really need it as bad to be honest.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1132943357
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/review/1335709178(a)github.com>
Source files with uppercase .F77 file extension do not syntax highlight when opened. .F90 works perfectly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3425
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3425(a)github.com>
Hi
I am learning C with Geany. When I write a function call like:
puts("
then Geany inserts a quote too much so that there are three:
printf(""");
The brackets are ok.
I am using Geany 1.38 on Linux mint.
Thank you for this nice editor
Sandor
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3426
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3426(a)github.com>
@b4n commented on this pull request.
> + static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+----------------------------------------------------------------------------- */
+{
+ return sci_get_char_at(sci, pos);
+}
> The [documented return type of `SCI_GETCHARAT`](https://www.scintilla.org/ScintillaDoc.html#SCI_GETCHARAT) is `int`, presumably for Unicode characters up to 32 bits in length.
No, that's probably either because `int` is "the" basic numerical type in C, or because of other historical reasons (and technically it is returned as a `sptr_t`). In practice, the returned value comes from `Document::ChatAt()` which returns a `char`. So if if want to be picky, it's actually a `char` stored into a `sptr_t`.
> Squeezing that into an 8-bit(?) `(g)char` needs an explicit cast.
Well, yes, but… actually no: this does not actually wrap `SCI_GETCHARAT`, but Geany's own wrapper, `sci_get_char_at()` *which has the exact same signature*.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1131695602
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/review/1333915171(a)github.com>
@rdipardo commented on this pull request.
> + static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+----------------------------------------------------------------------------- */
+{
+ return sci_get_char_at(sci, pos);
+}
> Just curious: why the wrapper?
The [documented return type of `SCI_GETCHARAT`] is `int`, presumably for Unicode characters up to 32 bits in length. Squeezing that into an 8-bit(?) `(g)char` needs an explicit cast.
The (implied) point that just using the returned `(g)int` without a cast is worth considering. At the same time, the `pos` argument might be safer as the (platform independent) [`Sci_Position` type]. The API structures that can *only* index 32-bit positions are [slated for eventual deprecation].
[documented return type of `SCI_GETCHARAT`]: https://www.scintilla.org/ScintillaDoc.html#SCI_GETCHARAT
[`Sci_Position` type]: https://github.com/geany/geany/blob/8a9e9be88545f83c91d378d6662790efa38959d…
[slated for eventual deprecation]: https://groups.google.com/g/scintilla-interest/c/mPLwYdC0-FE#:~:text=SCI_GE…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1131649908
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/review/1333866225(a)github.com>
@b4n commented on this pull request.
> + static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+----------------------------------------------------------------------------- */
+{
+ return sci_get_char_at(sci, pos);
+}
Just curious: why the wrapper?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#pullrequestreview-13337873…
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/review/1333787397(a)github.com>
Based off work from @hyperair that was merged at some point in #677, but reverted since then (see there). This adds a couple bits on top to fix some issues, and I believe the "meh no GTK2" whining of mine is lost to time and the fact there's no supported webkit for GTK2 anymore anyway.
BEWARE: this has been given little testing in the 2020s, I just rebased, merged a couple branches to the point there diffed empty, and did some very basic testing (it builds, it runs, and *seems* to work). Take it, leave it, improve it, comment on it, etc. I'll be there try not to forget looking at this for any comment though :wink:
NOTE: it's not at 100% feature-parity with the old version, mostly because of API changes regarding the inspector (II[RU]C, docking settings are not as controllable anymore), yet the inspector itself has seen countless improvements of course. But again, maybe things have changed since 2018.
See also #1217.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1224
-- Commit Summary --
* webhelper: Initial port to webkit2gtk
* webhelper: Initialize webkit favicon database
* webhelper: Fix ctrl+scroll zooming in gtk3
* webhelper: Port context menu to WebKitContextMenu
* webhelper: Use the right type for GSimpleAction
* webhelper: Port link hovering functionality to webkit2gtk
* webhelper: Fix constness of a variable
* webhelper: Add missing G_CALLBACK() casts
* webhelper: Avoid a deprecation
* webhelper: Make gtk3-only
* webhelper: Remove pre-GTK3 compatibility checks
* webhelper: Don't use deprecated GtkStock
* webhelper: Port inspector signal handlers to webkit2gtk
* webhelper: Fix flip-panes action
* webhelper: Remove custom docking position support
* webhelper: Fix loading progress display
-- File Changes --
M build/webhelper.m4 (5)
M webhelper/src/Makefile.am (3)
M webhelper/src/gwh-browser.c (762)
M webhelper/src/gwh-browser.h (11)
M webhelper/src/gwh-plugin.c (60)
M webhelper/src/gwh-settings.c (9)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1224.patchhttps://github.com/geany/geany-plugins/pull/1224.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1224
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1224(a)github.com>