Right now, when a config file from Tools->Configuration Files is edited for the first time, the global config file is taken and all lines in it are commented-out. When modified, such a file is copied into the user's config directory. The logic behind this is that the user typically wants to modify just one or few config options while leaving the rest in the default state.
However, commenting-out all lines is problemmatic. Consider for instance the beginning of filetypes.common when all lines are commented-out by the current code:
```ini
#~ # For complete documentation of this file, please see Geany's main documentation
#~ [styling]
#~ # use foreground;background;bold;italic or named_style,bold,italic
#~
#~ # used for filetype All/None
#~ #default=default
```
1. Already commented-out lines are commented out once more which is ugly
2. Sections are commented out. This is problematic because users don't have to just comment-out the variable they want to modify, they must also comment-out the section in which the variable is which is easy to forget.
3. Empty lines are commented out which is unnecessary
This patch goes through the config file line by line and keeps sections, comments and empty lines unmodified so the result of the above example is this:
```ini
# For complete documentation of this file, please see Geany's main documentation
[styling]
# use foreground;background;bold;italic or named_style,bold,italic
# used for filetype All/None
#default=default
```
The patch does this only for .conf filetype and uses the original code for other file types.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3413
-- Commit Summary --
* Improve code commenting-out global config files
-- File Changes --
M src/ui_utils.c (38)
-- Patch Links --
https://github.com/geany/geany/pull/3413.patchhttps://github.com/geany/geany/pull/3413.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3413
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3413(a)github.com>
These are two improvements of the comments discussed in #3413:
1. The indented `#command_example();` in
```ini
# set to false if a comment character/string should start at column 0 of a line, true uses any
# indentation of the line, e.g. setting to true causes the following on pressing CTRL+d
#command_example();
# setting to false would generate this
# command_example();
# This setting works only for single line comments
comment_use_indent=true
```
isn't a valid conf file line as `#` should be placed at the beginning of the line. This makes Scintilla to render `#command_example();` as if it weren't a comment. This patch changes this to
```ini
# set to false if a comment character/string should start at column 0 of a line, true uses any
# indentation of the line, e.g. setting to true causes the following on pressing CTRL+d
# #command_example();
# setting to false would generate this
# # command_example();
# This setting works only for single line comments
```
2. The patch replaces the not-very-English-sounding
```ini
# the following characters are these which a "word" can contains, see documentation
#wordchars=_abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789
```
with the following description from the documentation:
```ini
# these characters define word boundaries when making selections and searching
# using word matching options
#wordchars=_abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789
```
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3428
-- Commit Summary --
* Place # at the beginning of the line with the example in filetype conf files
* Reword "wordchars" description using the description from the manual
-- File Changes --
M data/filedefs/filetypes.Arduino.conf (4)
M data/filedefs/filetypes.CUDA.conf (7)
M data/filedefs/filetypes.Clojure.conf (7)
M data/filedefs/filetypes.Genie.conf (3)
M data/filedefs/filetypes.Graphviz.conf (7)
M data/filedefs/filetypes.Scala.conf (3)
M data/filedefs/filetypes.Swift.conf (3)
M data/filedefs/filetypes.TypeScript.conf (7)
M data/filedefs/filetypes.abaqus (7)
M data/filedefs/filetypes.actionscript (7)
M data/filedefs/filetypes.ada (7)
M data/filedefs/filetypes.asm (7)
M data/filedefs/filetypes.batch (7)
M data/filedefs/filetypes.c (7)
M data/filedefs/filetypes.caml (7)
M data/filedefs/filetypes.cmake (7)
M data/filedefs/filetypes.cobol (7)
M data/filedefs/filetypes.conf (7)
M data/filedefs/filetypes.cpp (7)
M data/filedefs/filetypes.cs (7)
M data/filedefs/filetypes.css (7)
M data/filedefs/filetypes.d (7)
M data/filedefs/filetypes.diff (3)
M data/filedefs/filetypes.docbook (7)
M data/filedefs/filetypes.erlang (7)
M data/filedefs/filetypes.f77 (7)
M data/filedefs/filetypes.forth (7)
M data/filedefs/filetypes.fortran (7)
M data/filedefs/filetypes.freebasic (7)
M data/filedefs/filetypes.gdscript (4)
M data/filedefs/filetypes.glsl (7)
M data/filedefs/filetypes.go (7)
M data/filedefs/filetypes.haskell (7)
M data/filedefs/filetypes.haxe (7)
M data/filedefs/filetypes.html (7)
M data/filedefs/filetypes.java (7)
M data/filedefs/filetypes.javascript (7)
M data/filedefs/filetypes.latex (7)
M data/filedefs/filetypes.lisp (7)
M data/filedefs/filetypes.lua (7)
M data/filedefs/filetypes.makefile (7)
M data/filedefs/filetypes.matlab (7)
M data/filedefs/filetypes.nsis (7)
M data/filedefs/filetypes.objectivec (7)
M data/filedefs/filetypes.pascal (7)
M data/filedefs/filetypes.perl (7)
M data/filedefs/filetypes.php (7)
M data/filedefs/filetypes.po (7)
M data/filedefs/filetypes.powershell (7)
M data/filedefs/filetypes.python.in (7)
M data/filedefs/filetypes.r (7)
M data/filedefs/filetypes.restructuredtext (7)
M data/filedefs/filetypes.ruby (7)
M data/filedefs/filetypes.rust (4)
M data/filedefs/filetypes.sh (9)
M data/filedefs/filetypes.smalltalk (7)
M data/filedefs/filetypes.sql (7)
M data/filedefs/filetypes.tcl (7)
M data/filedefs/filetypes.vala (7)
M data/filedefs/filetypes.verilog (7)
M data/filedefs/filetypes.vhdl (7)
M data/filedefs/filetypes.xml (7)
M data/filedefs/filetypes.yaml (7)
-- Patch Links --
https://github.com/geany/geany/pull/3428.patchhttps://github.com/geany/geany/pull/3428.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3428
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3428(a)github.com>
> > Nah, it happens that people learning Git can stuff it up so bad its easier to start again, no problem.
> Well, it usually is not easier, but people just don't know it :sweat_smile:
Thats learning :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1465349693
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1465349693(a)github.com>
- By the original design, the debugger allows thread context switching only
interactively, while in the Call Stack pane (in Stopped mode). This is
being handled directly through GtkTreeView::cursor-changed event.
- However, this event was also getting triggered when clearing the latest
thread's Call Stack after continuing the execution (Running mode).
- This behavior does not seem to have being intended, and it lead to a
number of issues: stepping hangs, corruption of GDB output processing,
unnecessary attempts at opening of source files corresponding to thread's
call-stack frames.
- To avoid all of these issues, GtkTreeView::cursor-changed event is left
unhandled while clearing the frames. Also the handler for thread-context
switching is allowed processing only in debugger's Stopped mode to enforce
the intended behavior.
Fixes #1069
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1170
-- Commit Summary --
* Debugger: Fix debugging of multi-threaded programs
-- File Changes --
M debugger/src/debug.c (4)
M debugger/src/stree.c (14)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1170.patchhttps://github.com/geany/geany-plugins/pull/1170.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1170
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1170(a)github.com>
> Nah, it happens that people learning Git can stuff it up so bad its easier to start again, no problem.
Well, it usually is not easier, but people just don't know it 😅
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1465191272
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1465191272(a)github.com>
Instead of breaking the flow, just force-push your branch: `git push -f origin bracketcolors_v1`. You probably can even revive this one by simply reopening it, and if GitHub isn't smart enough, there's a bunch of tricks we could do to force it's hand.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1465190977
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1465190977(a)github.com>
Nah, it happens that people learning Git can stuff it up so bad its easier to start again, no problem.
But unfortunately that disconnects the discussion.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1465065800
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1465065800(a)github.com>
For D and Python, we try to read the calltip from the constructor method (e.g. "__init__" for Python) instead of from the class tag itself. If we don't find a matching constructor method tag, now we continue looking at the class tag itself.
This is useful for global tags where the constructor signature might be defined on the class tag itself.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3334
-- Commit Summary --
* Use constructor method calltip only if available
-- File Changes --
M src/editor.c (14)
-- Patch Links --
https://github.com/geany/geany/pull/3334.patchhttps://github.com/geany/geany/pull/3334.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3334
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3334(a)github.com>