Hi, I'm working on updating the Geany package in nixpkgs from 1.38 to 2.0: https://github.com/NixOS/nixpkgs/pull/265362.
With Geany 2.0, [`tests/test_sidebar.c`](https://github.com/geany/geany/blob/2.0.0/tests/test_sidebar.c) fails on nixpkgs' automatic PR builder (ofborg) on macOS, but not on macOS locally - presumably due to the environment being headless in the former case. On Linux, `test_sidebar` succeeds both locally and on the builder. The issue would likely show up on Hydra as well, our central CI service, and would cause us to introduce workarounds that are probably avoidable.
The return value of [`gtk_init_check` here](https://github.com/geany/geany/blob/2.0.0/tests/test_sidebar.c#L145) is never examined. https://docs.gtk.org/gtk3/func.init_check.html says:
_"Note that calling any GTK function or instantiating any GTK type after this function returns FALSE results in undefined behavior."_
Could you please take a look at this? I can't really gauge what it would take to make the test run properly on Darwin in a headless environment (if possible). Worst case the test could skip itself and emit an appropriate message if GTK can't initialize, which would still be better than downstream having to explicitly work around it.
---
The build log for `x86_64-darwin` with the failing test can be viewed [here](https://logs.ofborg.org/?key=nixos/nixpkgs.265362&attempt_id=2ac562f8…. I attached it here in case that link becomes inaccessible: [geany_2.0_x86_64-darwin_ofborg_buildlog.txt](https://github.com/geany/geany…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3674
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3674(a)github.com>
Title says it all: instead of fetching the name from the deprecated ID, directly use the lexer name. This removes a deprecation warning, and probably aligns us for the future.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3668
-- Commit Summary --
* Use Scintilla lexer names rather than deprecated IDs
-- File Changes --
M src/highlighting.c (6)
M src/highlightingmappings.h (114)
M src/sciwrappers.c (17)
M src/sciwrappers.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/3668.patchhttps://github.com/geany/geany/pull/3668.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3668
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3668(a)github.com>
Creating all lexers takes between 200-300 microseconds on my ARM macBook and 1500-1800 microseconds on Raspberry Pi 4. So probably not something to worry about.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3673
-- Commit Summary --
* Test lexer creation speed
-- File Changes --
M src/highlighting.c (74)
M src/highlighting.h (1)
M src/libmain.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/3673.patchhttps://github.com/geany/geany/pull/3673.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3673
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3673(a)github.com>
On MacOS 14 locking the screen via shortcut (cmd ctrl q) is prevented if the cursor is in the text/edit field of an open file.
Locking via Touch ID button is still working.
I tested with Geany 1.38 and 2.0.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/49
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-osx/issues/49(a)github.com>
As @techee (IIRC) mentioned somewhere, the *Editor→Display* tab is getting crowded to the point it makes the prefs window grow. I suggest moving the *Virtual spaces* section to the *Editor→Features* tab that not only has room, but also seems more fitting to me – it's not a display thing, it's how the editor behaves, isn't it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3605
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3605(a)github.com>
"Editor -> Display" is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing.
Close #3605.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3643
-- Commit Summary --
* Move "Virtual Spaces" preference to "Editor -> Features"
-- File Changes --
M data/geany.glade (171)
-- Patch Links --
https://github.com/geany/geany/pull/3643.patchhttps://github.com/geany/geany/pull/3643.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3643
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3643(a)github.com>
I think that by default MAC dependencies should not be checked on non-MAC systems.
```console
+ export ASMFLAGS CFLAGS CXXFLAGS FFLAGS FCFLAGS LDFLAGS VALAFLAGS CC CXX FC AR NM RANLIB RUSTFLAGS VALAFLAGS
+ /usr/bin/meson setup --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --m
The Meson build system
Version: 1.2.3
Source dir: /home/tkloczko/rpmbuild/BUILD/geany-2.0.0
Build dir: /home/tkloczko/rpmbuild/BUILD/geany-2.0.0/x86_64-redhat-linux-gnu
Build type: native build
Project name: geany
Project version: 2.0.0
C compiler for the host machine: /usr/bin/gcc (gcc 13.2.1 "gcc (GCC) 13.2.1 20231011 (Red Hat 13.2.1-4)")
C linker for the host machine: /usr/bin/gcc ld.bfd 2.41-7
C++ compiler for the host machine: /usr/bin/g++ (gcc 13.2.1 "g++ (GCC) 13.2.1 20231011 (Red Hat 13.2.1-4)")
C++ linker for the host machine: /usr/bin/g++ ld.bfd 2.41-7
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (2.0.3)
Run-time dependency glib-2.0 found: YES 2.78.0
Run-time dependency gmodule-2.0 found: YES 2.78.0
Run-time dependency gtk+-3.0 found: YES 3.24.38
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency gtk-mac-integration found: NO (tried pkgconfig)
meson.build:26:22: ERROR: Dependency "gtk-mac-integration" not found, tried pkgconfig
A full log can be found at /home/tkloczko/rpmbuild/BUILD/geany-2.0.0/x86_64-redhat-linux-gnu/meson-logs/meson-log.txt
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3649
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3649(a)github.com>