While testing #3547 I noticed that both goto declaration and goto definition showed only the cases of the function in the `.hpp` file (the declarations), and not the cases in the `.cpp` file (the definitions) although both were open and the functions in the `.cpp` file showed in its symbols.
Doing goto on "handle" the line in the `.hpp` shows:
```C++
namespace CLI {
class Option_string : public Option {
...
public:
...
Err::Severity handle(string_view, string_view, size_t, const string&) override;
...
};
}
```
Matching line in `.cpp` does not show for goto declaration or definition:
```C++
Err::Severity CLI::Option_string::handle(string_view o, string_view v, size_t, const string&){
...
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3585
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3585(a)github.com>
The file **data/geany.glade** contains an unclear explanation of the option between either removal of an indent (removing possible multiple characters) or a character, see the property tooltip-text of **object class="GtkCheckButton"**, **id="check_backspace_unindent"**.
Instead of _"With the cursor in the indentation, pressing backspace unindents instead of deleting one character"_ I would suggest to re-write it to: **"With the cursor in the indentation, pressing backspace deletes it completely (removing multiple characters) instead of deleting a single character."**
(not urgent, see https://github.com/geany/geany/pull/3582#issuecomment-1753914348)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3588
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/3588(a)github.com>
OK, so here's my take on #3542. I realized that I actually liked most of the stuff, it was just a matter of different presentation and some implementation details.
I think from the discussion in #3542 it was clear that most people wanted to see the path and line number and to to be able to distinguish it from the signature easily - the core thing was to use a different font for the file name (italics) and for the signature (small monospaced font). For the tooltip, I just separated these two by a newline.
In more details, this is what I did:
1. Show signature for all tag types using get_symbol_name() when get_symbol_tooltip() returns NULL. Modify get_symbol_name() to drop line number when needed. (More or less taken over the complete implementation from Colomban)
2. Add scope information to the signature both when using get_symbol_name() and get_symbol_tooltip(). (Based on Nick's idea)
3. Truncate the length of the popup to at most 80 characters (More or less taken over the complete implementation from Nick)
4. Improve formatting of entries in the popup so individual pieces of information are easier to distinguish:
- file name and line number are always in italics
- the following signature is in small monospaced font
5. Add tooltip to every entry (based on Nick's implementation).
- split the tooltip into two lines - the first line shows the file and the line number, the second line the signature
- both of the lines are formatted in the same way as described in (4)
(Thanks to Nick Treleaven and Colomban Wendling for the original implementation.)
@b4n @ntrel @elextr @kugel- What do you think? (Pinging about everyone, this will be one of those features where we'll all have a different opinion and hate each other with passion ;-)
The result looks something like this:
<img width="995" alt="Screenshot 2023-08-23 at 22 40 37" src="https://github.com/geany/geany/assets/713965/7ddc4946-06fa-4424-8…
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3547
-- Commit Summary --
* Improve tag-goto popup
-- File Changes --
M src/symbols.c (42)
M src/tagmanager/tm_parser.c (20)
M src/tagmanager/tm_parser.h (3)
-- Patch Links --
https://github.com/geany/geany/pull/3547.patchhttps://github.com/geany/geany/pull/3547.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3547(a)github.com>
Extends [#1233](https://github.com/geany/geany-plugins/pull/1233) to add support for Lua 5.1 and LuaJIT by adding compatibility functions/defines. The build script is fixed to not ignore the `--with-lua-pkg` option and to recognize Lua variants: lua, lua53, lua54, lua52, luajit, lua51 (currently in this order). Systems that use a different basename will have to explicitly specify the name, eg lua5.1 or lua-5.1, during configure. To change variants, reconfigure and rebuild.
```
./configure --with-lua-pkg=[lua]
make -C geanylua clean
make -C geanylua
```
Supercedes #1231, #1233, #1235. Resolves #1228, #1133.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1238
-- Commit Summary --
* GeanyLua: Use luaL_Reg instead of luaL_reg
* GeanyLua: Don't ignore with-lua-pkg configure option
* GeanyLua: Add support for Lua 5.2+
* GeanyLua: Add compatibility for Lua 5.1 and LuaJIT
-- File Changes --
M build/geanylua.m4 (28)
M geanylua/Makefile.am (2)
M geanylua/glspi.h (2)
M geanylua/glspi_app.c (4)
A geanylua/glspi_compat.c (55)
A geanylua/glspi_compat.h (28)
M geanylua/glspi_dlg.c (6)
M geanylua/glspi_doc.c (4)
M geanylua/glspi_init.c (4)
M geanylua/glspi_kfile.c (10)
M geanylua/glspi_run.c (30)
M geanylua/glspi_sci.c (6)
M geanylua/gsdlg_lua.c (11)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/1238.patchhttps://github.com/geany/geany-plugins/pull/1238.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1238
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1238(a)github.com>
Any chance this could make it into geany-plugins v2.0? 👀
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1754053448
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/c1754053448(a)github.com>
This is an update of the Dutch translation. Some suggestions for clarification of the original **msgid** texts:
- As for end-users the subtle distinction between removal of an indent (removing possible multiple characters) or a character may be unclear, please clarify like "With the cursor in the indentation, pressing backspace unindents **(removing posible multiple characters)** instead of deleting **single** character"
- A hyperlink is present four times in the text. Please add a GUI hyperlink instead : https://docs.gtk.org/glib/method.DateTime.format.html.
- The string **"_Join Lines"** doesn't explain the sequence of how the lines are joined. A description like **"Concatenate Lines"** would fit better I think.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3582
-- Commit Summary --
* Update nl.po
-- File Changes --
M po/nl.po (200)
-- Patch Links --
https://github.com/geany/geany/pull/3582.patchhttps://github.com/geany/geany/pull/3582.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3582
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3582(a)github.com>