GCC 8 introduced `-Wsizeof-pointer-div` which is enabled by `-Wall` and
warns for sizeof divisions that look like they would compute the size
of a static array but are called on something on which this doesn't
work (e.g. a pointer as LHS). This is quite reasonable and useful, but
it fails to detect the case where the computation is guarded against
being called on problematic values, like our HL_N_ENTRIES() macro that
accepts NULLs but won't use the sizeof computation result then.
Work around this by implementing HL_N_ENTRIES() macro in a way that
cannot trigger such a warning yet yield the same result.
Example warning:
```
../../src/highlighting.c: In function ‘highlighting_init_styles’:
/usr/include/glib-2.0/glib/gmacros.h:351:42: warning: division ‘sizeof (HLKeyword * {aka struct <anonymous> *}) / sizeof (HLKeyword {aka struct <anonymous>})’ does not compute the number of array elements [-Wsizeof-pointer-div]
#define G_N_ELEMENTS(arr) (sizeof (arr) / sizeof ((arr)[0]))
^
../../src/highlightingmappings.h:74:48: note: in expansion of macro ‘G_N_ELEMENTS’
#define HL_N_ENTRIES(array) ((array != NULL) ? G_N_ELEMENTS(array) : 0)
^~~~~~~~~~~~
../../src/highlighting.c:966:5: note: in expansion of macro ‘HL_N_ENTRIES’
HL_N_ENTRIES(highlighting_keywords_##LANG_NAME)); \
^~~~~~~~~~~~
../../src/highlighting.c:1011:3: note: in expansion of macro ‘init_styleset_case’
init_styleset_case(CONF);
^~~~~~~~~~~~~~~~~~
```
---
Another solution could be reporting a bug to GCC for it to detect our use case and avoid the warning then, but that might or might not be much meaningful, and won't fix the issue on currently affected GCC versions anyway.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2398
-- Commit Summary --
* Rewrite HL_N_ENTRIES macro to avoid a GCC8 false positive warning
-- File Changes --
M src/highlightingmappings.h (12)
-- Patch Links --
https://github.com/geany/geany/pull/2398.patchhttps://github.com/geany/geany/pull/2398.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2398
Related to https://github.com/geany/geany/issues/2185 and https://github.com/geany/geany/issues/2180,
I know that _"The colour scheme set for the editor widget where the code is, is again totally independent of any terminals, it's only used to style syntax highlighting of code in the documents notebook"_, but it is creating high-contract and not easy on the eyes.
This is what i get out of the box:
I.e., the editor widget is light-on-dark, while the side bar and the message windows are both dark-on-light. Such high-contract between the windows will make the eyes fatigue easily.
Please consider having a unified colour scheme on all three windows to easy the eyes. Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2196
When using the autocomplete feature in Geany on MacOSX 10.14 Mojave in fullscreen mode, the autocomplete opens in a separate desktop (fullscreen) rather than as a small popup in the editor.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/18
Fixed deprecated gtk3 calls. The PR unfortunately includes an ugly list of all the GTK stockitems as I did not see a different solution.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/865
-- Commit Summary --
* commander: fixed deprecated gtk3 calls
-- File Changes --
M build/commander.m4 (1)
M commander/src/Makefile.am (7)
M commander/src/commander-plugin.c (22)
M utils/src/Makefile.am (3)
A utils/src/gp_gtkcompat.c (222)
M utils/src/gp_gtkcompat.h (5)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/865.patchhttps://github.com/geany/geany-plugins/pull/865.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/865
Geany's markdown syntax highlighting (without the markdown plugin) is confused, when image link without title is used:
```
```
All the following text is highlighted bold (same as the link itself).
Also the following markdown syntax is ignored - see ```*Obecné*``` is not in italics.
When I fill in some title to image link
```
```
then the highlighting became correct (i.e. only link itself is bold).
Also the following markdown syntax is ok then (*```*Obecné*```* **is** in italics).
The correct behavior is to highlight bold only the link even if its title is empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2798
I'm using the geany 1.32 default installation on ubuntu 18.04 64bit to edit test.md file.
for H1 - H6 headers, the "#" signs are bold, but not the rest of header, i.e. "# Header" only has bold for '#' not for the word 'Header'.
`**bold**` does not show bold, neither does `*italiic*` displays italic.
I can customize them all using filetypes.markdown, except for the H1-H6 headers, the header is not impacted at all as mentioned above, for example:
`header1=0xFFCB4F;0x1E1E1E;true;false` this change will make `#` bold with specified background/front color, but not the header content, i.e. "Header1" in `# Header1` stays non-bold.
At least I would like to have all markdown headers shown as bold inside Geany without the need of any previewer
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2026
I'm not sure how robust our parser is against invalid input or updated ctags file format so better use the upstream version of the official library to parse ctags files so we don't have to worry about this.
In addition, this patch also updates the code to read all the ctags kinds we need in tagmanager.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3049
-- Commit Summary --
* Add ctags 'readtags' library to allow us parse ctags files
* Use the readtags library to parse ctags files
-- File Changes --
M ctags/Makefile.am (2)
A ctags/libreadtags/readtags.c (1310)
A ctags/libreadtags/readtags.h (295)
M src/tagmanager/Makefile.am (1)
M src/tagmanager/tm_source_file.c (174)
-- Patch Links --
https://github.com/geany/geany/pull/3049.patchhttps://github.com/geany/geany/pull/3049.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049
Most likely the string doesn't make sense to be transalted
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/587