> You, yourself, participated in discussion in that PR.
So? That doesn't mean I remember it, thats why I searched.
> I closed the PR because we had reached an impasse that made it highly unlikely that the PR would be accepted.
Well, thats what happens when all requests for changes are rejected.
I just re-skimmed it and those involved seem to be trying to address the concerns they have so it _can_ be accepted. But the sticking points seem to be:
1. the unconditional "hide on startup" instead of the usual "restore whatever the state was when shutdown" that all other UI settings have, and
2. the lack of a fixed documentable method to bring the menubar back.
A user settable keybinding can't be documented as the manual doesn't know what the user set it to, and unfortunately mnemonics don't work when the menubar is hidden, and no alternative was suggested AFAICT. I guess an item could be added to the right click menu if the main menu is hidden, but nobody thought of it at the time.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151827196
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151827196(a)github.com>
I would also prefer that the state is preserved, but this could be an informed preference. No 'View' menu option instead 'Hide/Show menu bar' and 'preserve state' preferences with a note that a keyboard shorcut could be set. What do you think @xiota?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151827103
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151827103(a)github.com>
@elextr
You, yourself, participated in discussion in that PR.
I closed the PR because we had reached an impasse that made it highly unlikely that the PR would be accepted.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151788429
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151788429(a)github.com>
> See https://github.com/geany/geany/pull/2972 and https://github.com/geany/geany-plugins/pull/1138.
Oh well, #2972 didn't show in my search because it is closed, and I didn't look for plugins.
> Core Geany devs appear to simply not want menubar hiding to be included in Geany.
_Most_ don't, so clearly those are not going to work on it, and since the PR was only open for a month none of those who might accept it had time to look at it. (I guess its Murphys law that the ones who might accept it are those with least time available for Geany :-)
Not sure what the availability of the plugin collection maintainer is, but I'm sure its not great, so if nobody else tried, tested, and supported the plugin it is likely they didn't spend any effort on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151784895
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151784895(a)github.com>
> A View menu option with a warning and a keyboard shorcut, or/and an informed preference setting with reference in the manual or the faq or even an unsetted keyboard shorcut option would be amazing.
@asoymos It's been a while since I looked at that patch, but everything you mention is in that patch except for the menu option. A major sticking point with core devs is the menu state when Geany is restarted. They seemed to want the option to keep the menu hidden to be removed, which in my opinion, defeats the purpose of having the option to hide the menu in the first place.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151782713
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151782713(a)github.com>
One of the things I like more about open source is the simplicity needed for maintain something without income for a long period of time. That for me means that you can´t think of all use cases but that you share your own and leave it open to others to contribute if needed. I read [#2972](https://github.com/geany/geany/pull/2972) and for me everything that needs to be said had been. A View menu option with a warning and a keyboard shorcut, or/and an informed preference setting with reference in the manual or the faq or even an unsetted keyboard shorcut option would be amazing. Again, in my opinion. Thanks anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151775404
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151775404(a)github.com>
@asoymos
It is not true that no one ever made a pull request to include the feature. See #2972 and geany/geany-plugins#1138.
Core Geany devs appear to simply not want menubar hiding to be included in Geany.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151755146
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151755146(a)github.com>
An informed preference with keyboard shorcut would be great for both prevent accidents and extend customizability in my opinion. Just my two cents.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151752931
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151752931(a)github.com>
> So they are not going to make a PR, and nobody else has.
Not true. I did (#2972). There was no agreement on details of operation. So I closed it, and moved functionality to a proposed new plugin (geany/geany-plugins/#1138). It sat around with no sign of interest. So I closed it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151752615
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151752615(a)github.com>
From various discussions over years most of the Geany devs are not in favour of menu hiding mostly because of the "hidden by accident and can't find how to get it back" and the "not everything can be performed from the keyboard" problems. So they are not going to make a PR, and nobody else has.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-1151749396
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/issues/633/1151749396(a)github.com>