This commit moves all access to TMSourceFiles/the tagmanager API into a dedicated file ```tm_control.c```. Calls from the workbench plugin to the tag-manager API may now only appear in this file. Also all calls are synced using a idle-queue managed in ```idle_queue.c``` (using ```plugin_idle_add()```). This way the file lists in the workbench projects is completely de-coupled of any TMSourceFile related data/references. Fixes #866.
(Calls to the tag-manager API were synced before also. But the implementation was not very clean and therefore contained errors/code where the tag-manager API was called directly - which could lead to crashes)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/867
-- Commit Summary --
* workbench: revised tag-manager control/usage
-- File Changes --
M workbench/src/Makefile.am (6)
A workbench/src/idle_queue.c (134)
A workbench/src/idle_queue.h (33)
M workbench/src/plugin_main.c (31)
A workbench/src/tm_control.c (243)
A workbench/src/tm_control.h (31)
M workbench/src/wb_project.c (346)
M workbench/src/wb_project.h (9)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/867.patchhttps://github.com/geany/geany-plugins/pull/867.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/867
This PR adds a simple config option to disable or enable tree lines in the workbench's sidebar tree.
(This also adds the missing description for the option _"Expand on hover"_ to the README file)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/869
-- Commit Summary --
* workbench: added option to enable or disable tree lines
-- File Changes --
M workbench/README (8)
M workbench/src/dialogs.c (25)
M workbench/src/plugin_main.c (2)
M workbench/src/sidebar.c (3)
M workbench/src/workbench.c (48)
M workbench/src/workbench.h (2)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/869.patchhttps://github.com/geany/geany-plugins/pull/869.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/869
![Screenshot from 2019-05-22 16-53-06](https://user-images.githubusercontent.com/24701640/58180225-63afc…
1. The window title "**Question**" is not really that appropriate, and confuses more than explains. Better would be for example "**Wrap search?**"
2. The line "**'String' was not found.**" is actually wrong. When the string was not found, the search field gets red and in the status bar it says exactly "'String' was not found." But whenever this "Question" window is shown, it always means that the **search has reached the end of the file**, and it would like to start from the beginning (not necessarily "again" - see point 3.) in order to confirm that the string was really not found.
3. "**Wrap search and find again?**" I think " and find again" here is unnecessary. Just "**Wrap search?**" would suffice.
4. The "**Find**" button perhaps should better be "**Wrap**".
5. #1192 The default button should indeed be **Yes/OK/Wrap/Find** (not Cancel).
6. #2159 When the wrap is done, perhaps it should also **say that in the status bar** (or it should be muted if the feature "Show message in the status bar when the search is wrapped" will be implemented and "Always wrap search" option is disabled)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2160
Is there any way to work with a current text selection with the Macro Plugin? I need to prepend/append a tag pair to selected text. I currently can do this with single words by coding `Ctrl-Left, Ctrl-Right` into the macro, but I would like the ability to span multiple words so that they all were included in the tag pair.
I don't see a way of doing this, but geany can do it to multiple words via the Edit/Format menu, and that got me wondering.
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/871
I am sure I found an error where a new user to Geany is unable to drag and drop a file unto Geany causing Geany to open it; however, when I installed Geany first then it would not allow me to drop files on it; because of that, I was going to uninstall, until a friend told me to try again.
Geany 1.35
"
SiSoftware Sandra (SiSoftware Sandra ..)
...
Operating System
Windows System : Microsoft Windows 7 Ultimate 6.1.7601 (Service Pack 1)
Platform Compliance : x64
"
Files tested (drag and drop onto Geany).
C, C#, C++, Perl.
Bug disappeared* after:
- reopening program a couple of times,
- adding new tab,
- removing tab,
- .. (was not an exhaustive test)
*: Files started opening when dragged and doped on Geany.
The whole bug, if it not unique to my system,
makes Geany look bad when tested by new users.
Greetings from Eve-Online
Geany -v
is in picture, and there does not exist a dott conf file.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2165
**Is your feature request related to a problem? Please describe.**
Syntax highlighting doesn't turn of when I open a file with dts extension
**Describe the solution you'd like**
Geany to pick C-like source highlighting
**Describe alternatives you've considered**
**Additional context**
https://www.kernel.org/doc/Documentation/devicetree/booting-without-of.txt:… format of the .dts "source" file is "C" like, supports C and C++
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2164
_Story:_
Besides searching for keywords like variables or unique words in codes, one also sometimes just want to search for special symbols like "\t" or "\n" for some reasons. One would activate "regular expression" for this, but still, "\n" will not be found, unless "multi-line matching" is activated.
_Suggesting:_
To have an extra option for **multi-line matching** is somehow useless, this **should** obviously **be the default if searching for regular expression**. This also would simplify the search/replace dialog a bit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1588
It might be useful to have an [`ISSUE_TEMPLATE`][0] file that people fill out when submitting new Github Issues. Although it adds a slight [PITA][1] when submitting bug reports, it should help to avoid the common back-and-forth at the start of most issues to request useful information.
I have written [one such template][2]. The "Prerequisites" section is based on the most common missing/wrong things I've seen in submitted issues. Perhaps it belongs in a `CONTRIBUTING` file instead, but putting it inline in the [`ISSUE_TEMPLATE`][0] makes sure people have to explicitly ignore it.
For now don't worry about spelling or grammar mistakes, but I'm interested to see whether this is wanted at all, and whether any sections or items should be added or removed. We can get the exact spelling and wording fine-tuned when I make an actual pull request.
Feel free to [try it out][3] on my testing repository.
[0]: https://help.github.com/articles/about-issue-and-pull-request-templates/
[1]: http://onlineslangdictionary.com/meaning-definition-of/pita
[2]: https://github.com/codebrainz/geany-issue-template
[3]: https://github.com/codebrainz/geany-issue-template/issues/new
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2063
){kind=link}