At the moment there's a problem with keybinding creation and processing.
When a keybinding is accessed using shift such as the zoom in keybinding
`Ctrl-+` which on English keyboard requires pressing `<Ctrl><Shift>=`, the
`<Shift>` key is preserved right now. This is visible when changing
keybindings - pressing the above key combination leads to
`<Primary><Shift>+`. This is incorrect - the keybinding should either
be `<Primary><Shift>=` or `<Primary>+` but in `<Primary><Shift>+` there's
extra `<Shift>` which leads to problems.
On linux the problems aren't so much visible - the problem is visible
when changing keybindings as mentioned above. Even though this
particular keybinding isn't executed through on_key_press_event()
because the combination `<Primary><Shift>+` doesn't correspond to the
default `<Primary>+` value, it's executed by GTK as an accelerator so
the problem isn't directly visible.
This might however break when a user modifies this keybinding to the
wrong value `<Primary><Shift>+` and when the user is using multiple
keyboards such as English where + has to be accessed over shift
and German where typing + doesn't require shift. The keybinding will
stop working on the German keyboard in this case because of the
extra shift.
On MacOS the accelerator isn't executed for some reason and non-
letter keybindings don't work when shift is used.
To fix the issue we can use gdk_keymap_translate_keyboard_state()
which reports "consumed" modifiers - that is those which lead to
typing the secondary character. However, we don't want this to happen
when typing alphabetical characters because it's easier to notice
the use of shift in `<Ctrl><Shift>r` than in `<Ctrl>R`. Modifier
consumption is undone in this case.
Should also fix https://github.com/geany/geany/issues/694
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1633
-- Commit Summary --
* Normalise key events when creating/processing keybindings
* Eliminate keybindings_check_event()
-- File Changes --
M src/keybindings.c (44)
M src/keybindings.h (2)
M src/prefs.c (16)
-- Patch Links --
https://github.com/geany/geany/pull/1633.patchhttps://github.com/geany/geany/pull/1633.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1633
I have build and installed geany-master with the G_IO bug workaround. It is installed and running.
```
# which geany
/usr/local/bin/geany
```
but when I try to build the plugins package from master it fails to find geany.
```
./autogen.sh
......
checking for GEANY... no
configure: error: Package requirements (geany >= 1.29) were not met:
```
Package 'geany', required by 'virtual:world', not found
What's that about? Have I missed a step ?
thx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/666
According to the instructions I should be able to run either ./configure or ./autogen.sh, however, configure file is missing and autogen.sh fails because "macro AM_GLIB_GNU_GETTEXT not found in library".
Should the ./configure file exist or should the instructions be corrected? I assume autogen.sh fails because of missing dependencies? Can they be pulled in automatically?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/379
This adds _string variants to 3 msgwin_{compiler,status,msg}_add(), since those cannot be gobject-introspected (functions with variadic arguments generally can't because the parameters couldn't be marshalled).
So I simply add _string variants which take the string after g_strdup_vprintf(). I found that two of them already existed, so I only needed to add one and export all 3 to plugins.
@sagarchalise wants this in peasy and the functions are currently not available in any form.
GEANY_API_VERSION increment is TODO, will do once this lands.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1748
-- Commit Summary --
* api: add non-variadic variants of msgwin_*_add to the API
* msgwin: beautify doxygen comments a bit
-- File Changes --
M src/msgwindow.c (117)
M src/msgwindow.h (3)
-- Patch Links --
https://github.com/geany/geany/pull/1748.patchhttps://github.com/geany/geany/pull/1748.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1748
…and fix the current documentation not to lie to the reader :)
AFAIK this still isn't configurable by color shemes (IIUC only *named styles* and *named colors* are supported), but not configurable at least from *filetypes.common*.
@codebrainz assigning to you as I would thing you are the most colorscheme-literate of us.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/917
-- Commit Summary --
* Fix documentation about translucency settings
* Make the search marker translucency configurable
-- File Changes --
M data/filetypes.common (9)
M doc/geany.txt (22)
M src/highlighting.c (6)
-- Patch Links --
https://github.com/geany/geany/pull/917.patchhttps://github.com/geany/geany/pull/917.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/917
Hello.
One the status bar where one can see the line number, column, selection, etc. there is a value called Scope. When I am within a perl subroutine the scope is the subroutine. However, if the cursor is not within a subroutine, the scope would be the whole file but not unknown in my opinion.
Thanks for reading.
LA
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1484
If I click on the help button in the Plugin Manager then it shows me the help for that plugin. This usually works fine.
But if I enable and disable a plugin a few times and click on help after that, then geany will crash quite likely. This happens no matter if the plugin is using the old or new plugin API. Also the kind of help shown does not seem to make a difference, e.g.:
- the Latex plugin opens a info dialog
- other plugins open a webpage
In both cases I could re-produce the crash. I tested with a quite actual development version of geany under Ubuntu 16.04, GTK3 build.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1781
If the preference *Ensure new line at file end* is enabled, Geany adds a newline even to a completely empty file, so it’s impossible to save a file of 0 bytes.
While strictly speaking this does just what the preference label says, in practice the point of this feature, I think, is to ensure that *every line ends* with a newline, so it shouldn’t apply when there are no lines.
That’s what the other editors (nano, vi, emacs) do — they only add a newline to a non-empty file.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1539
We have strings like:
```
_Fold All
_Unfold All
_Expand All
_Collapse All
Fold/unfold all children of a fold point
Fold or unfold all children of a fold point. By pressing the Shift key while clicking on a fold symbol the contrary behavior is used.
```
Perhaps they should all use collapse/expand.
And perhaps use the same strings multiple places.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1793