…and fix the current documentation not to lie to the reader :)
AFAIK this still isn't configurable by color shemes (IIUC only *named styles* and *named colors* are supported), but not configurable at least from *filetypes.common*.
@codebrainz assigning to you as I would thing you are the most colorscheme-literate of us. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/917
-- Commit Summary --
* Fix documentation about translucency settings * Make the search marker translucency configurable
-- File Changes --
M data/filetypes.common (9) M doc/geany.txt (22) M src/highlighting.c (6)
-- Patch Links --
https://github.com/geany/geany/pull/917.patch https://github.com/geany/geany/pull/917.diff
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917
:+1: Thanks for putting this together!
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-188963142
Not sure if I like this better than adding a 3rd field to the `translucency` key. My main problem is that it's called `marker_search_translucency`, but it's not at all a marker. At least the stuff in `translucency` controls things which resemble indicators (that is, highlighted parts of the text area, as opposed to markers in the margin). The comments and doc changes also further conflate markers and indicators.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-189063567
@codebrainz yeah, its not a good name, but its just a continuation of the current confusion, this is the translucency setting for the thing above that is (incorrectly) called `marker_search`.
I don't think we want to change existing names (do we?) so this is the best name in the circumstances and IMHO more appropriate than adding it to a translucency setting for something unrelated.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-189075648
IMO, it'd be better to not continue the confusing terms. On the other hand, it won't add much extra work/breakage if/when I eventually get around to making a PR to sort out the confusing terms in the conf files and UI.
--- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-189118310
Ok, so I got a chance to try this patch against v1.27.0. It seems like the problem still occurs and I've verified that my local install is using the correct libgeany (from `/usr/local/libgeany..` instead of `/usr/lib/libgeany...`). I've tried setting both `marker_search_translucency=0;0` and `marker_search_translucency=255;255` but the resulting translucency is the same after restarting geany. Changing other values in the theme like the `marker_search` color works just fine.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-215209374
@mscdex How did you set the value? As said in the first message, this still isn't configurable in the theme AFAIK, but it works just fine though `filetypes.common`:  (using `marker_search_translucency=255;32` here)
@codebrainz any objection to merging this? Ideally yeah all the key names should be improved, but well. Also, allowing themes to configure that would be nice too, but that also requires a little work. IMO this is good enough for the moment, and can be enhanced together with the existing stuff if someone cares enough.
Note for Windows 95, 98 and ME users:
- keep this value at 256 to disable translucency otherwise Geany might crash.
- keep this value at 255 to disable translucency otherwise Geany might crash.
We could probably remove this whole note since AFAIK we don't support anything older than Windows XP (if even that).
Only the first and second arguments are interpreted.
- *Example:* ``translucency=256;256;false;false``
- *Example:* ``translucency=255;255;false;false``
Maybe it could say "Only two arguments are interpreted" and then not show the `;false;false` in the example?
@@ -4616,15 +4624,15 @@ marker_mark *Example:* ``marker_mark=0x000000;0xb8f4b8;false;false``
marker_translucency
- Translucency for the line marker (first argument) and the search marker
- (second argument). Values between 0 and 256 are accepted.
- Translucency for the line marker (first argument) and the mark marker
What's a "mark marker"? Is it the search indicator?
Only the first and second arguments are interpreted.
- *Example:* ``marker_translucency=256;256;false;false``
- *Example:* ``marker_translucency=255;255;false;false``
Same note here about showing needless `;false;false` in example.
Seems OK to me.
@@ -4616,15 +4624,15 @@ marker_mark *Example:* ``marker_mark=0x000000;0xb8f4b8;false;false``
marker_translucency
- Translucency for the line marker (first argument) and the search marker
- (second argument). Values between 0 and 256 are accepted.
- Translucency for the line marker (first argument) and the mark marker
it's `GCS_MARKER_MARK`, "user marker" may be slightly better?
@@ -4616,15 +4624,15 @@ marker_mark *Example:* ``marker_mark=0x000000;0xb8f4b8;false;false``
marker_translucency
- Translucency for the line marker (first argument) and the search marker
- (second argument). Values between 0 and 256 are accepted.
- Translucency for the line marker (first argument) and the mark marker
the other documentation (on <kbd>^M</kbd>, <kbd>^.</kbd> and <kbd>^,</kbd>) calls those "markers" only, and some other parts refers to them as "bookmarks".
@b4n @codebrainz is this still happening and still wants a review, or is it abandoned?
It'd be nice to be able to change the value from themes also.
@mscdex IIUC all that would need is for the filetypes.common entry to refer to a name, so if this goes ahead that would be a minor later change.
Updated for up-to-date-ness and to fix review comments.
Might be nice to review the [geany-themes](https://github.com/geany/geany-themes) to see if this could be useful. Maybe I'll do it some day...
github-comments@lists.geany.org