kugel- commented on this pull request.
> @@ -2067,8 +2055,14 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
foreach_strv(ext, extensions)
{
+ if (**ext == '.')
+ {
+ g_warning(_("Proxy plugin '%s' extension '%s' starts with a dot. "
+ "Please fix your proxy plugin."), p->info.name, *ext);
+ }
Yep
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1233
> and if it's a casual thing, it's just as easy to forget.
Maybe we are misunderstanding, but I would have thought the casual/accidental keybinding user was the one that needed the reminder.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-247569286
It is very hard to debug if the proxy plugin happens to give extensions starting with a dot. If they do, detect this case, warn in the debug messages, and fix the extension. It seems unlikely that files with two dot extensions will be desired, so it should case no harm.
Note that it is documented to provide extensions without the dots, but it's easy to miss that one place (and in the proxy howto). IMO, we should at least print a warning for this case if not also fix the extension like in this PR.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1212
-- Commit Summary --
* Gracefully handle proxies registering invalid extensions
-- File Changes --
M src/plugins.c (14)
-- Patch Links --
https://github.com/geany/geany/pull/1212.patchhttps://github.com/geany/geany/pull/1212.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1212
> But should probably have an "are you sure" dialog, keybindings get hit accidently.
You think? If the user "frequently" toggles the menubar, it'll be annoying, and if it's a casual thing, it's just as easy to forget.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-247566612
b4n commented on this pull request.
> @@ -2067,8 +2055,14 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
foreach_strv(ext, extensions)
{
+ if (**ext == '.')
+ {
+ g_warning(_("Proxy plugin '%s' extension '%s' starts with a dot. "
+ "Please fix your proxy plugin."), p->info.name, *ext);
+ }
Maybe, but then it probably has to be outside the loop actually registering the `PluginProxy`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1233
kugel- commented on this pull request.
> @@ -2067,8 +2055,14 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
foreach_strv(ext, extensions)
{
+ if (**ext == '.')
+ {
+ g_warning(_("Proxy plugin '%s' extension '%s' starts with a dot. "
+ "Please fix your proxy plugin."), p->info.name, *ext);
+ }
How about returning false here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1233#pullrequestreview-325073
> and I could suppose that if someone set a custom keybinding for it, they should know they did it.
But should probably have an "are you sure" dialog, keybindings get hit accidently.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-247563114
> This will likely cause some confusion for people who have lost their menu and can't get it back, if it's not done carefully. The UI to bring the menu back (ex. preferences, view menu, etc) won't be accessible, and having a single keybinding, which can't be inspected since preferences won't be available, is not a very discoverable way to bring it back.
A simple mean could be add a keybinding only (no entry in the menu), and leave it unbound by default. That's not an awesome UI, but it's easy to do, and should prevent anyone not having explicitly opted in to the feature from losing their menubar; and I could suppose that if someone set a custom keybinding for it, they should know they did it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/633#issuecomment-247555885
Geany 1.28 Release (Windows and Linux) and also Geany 1.29 "Jowar" (Windows)
"Document/Set Lineend/Set to CR/LF and convert"
is in german translation
"Dokument/Zeilenenden festlegen/Auf CR/LF setzen und umwandeln (Winows)"
should be
"Dokument/Zeilenenden festlegen/Auf CR/LF setzen und umwandeln (Windows)"
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1219