When `doc == doc_b`, `pos` should not increment since if the tab is moving from left to right (like when saving an untitled document to a new file), the target position should be `pos - 1`.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
I would like to have the possibility to see more lines beneath the cursor when the cursor is near the bottom of the text edit pane.
@b4n mentioned in the last paragraph of [his comment](https://github.com/geany/geany/issues/1116#issuecomment-230763662) to issue #1116
> However, we could indeed set [the Y caret policy](http://www.scintilla.org/ScintillaDoc.html#SCI_SETYCARETPOLICY) with an offset so the last line is never on the bottom, something like `SCI_SETYCARETPOLICY(CARET_SLOP | CARET_STRICT | CARET_EVEN, 1).`
> I guess that'd be reasonable, but may require a setting.
So my feature request is: Please implement such a setting, but please with more than just one single line - it would be nice to be able to freely set the number of lines.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1152
Construct a dummy TMTag array containing keywords, filter them similarly
to workspace and global tags and show them together with normal tags
in the autocomplete popup.
Could probably be optimized by not doing all the stuff all the time but
the CPU time spent on this is probably just a noise compared to all the
TM stuff.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1146
-- Commit Summary --
* Add keywords to the autocompletion list
-- File Changes --
M src/editor.c (24)
M src/highlighting.c (20)
M src/highlighting.h (2)
M tagmanager/src/tm_workspace.c (6)
M tagmanager/src/tm_workspace.h (2)
-- Patch Links --
https://github.com/geany/geany/pull/1146.patchhttps://github.com/geany/geany/pull/1146.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1146
This is the patch I was talking about which moves TM-related things around a bit (can be changed if anyone prefers different locations/directory naming etc.). There are just two things missing:
1. I haven't updated the makefile.win32 files - is it worth updating them or can they be removed completely? Are they still needed for something?
2. There should probably be some kind of makefile that builds ctags when run inside either ctags/main or ctags/parsers (right now it's only in the ctags directory). There's something similar in universal-ctags too, I just wasn't sure what's the right way to do it for Geany. I'd leave this to someone with better automake knowledge (should be easy).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1070
-- Commit Summary --
* Move TM into src
* Use the single-file implementation of MIO from universal-ctags
* Separate ctags into parsers and main sources
* Update paths for doxygen
* Update various comments mentioning tagmanager/src
* Rename js.c to jscript.c to match universal-ctags
-- File Changes --
M HACKING (2)
M Makefile.am (2)
M configure.ac (6)
A ctags/Makefile.am (89)
R ctags/main/args.c (0)
R ctags/main/args.h (0)
R ctags/main/ctags.c (0)
R ctags/main/ctags.h (0)
R ctags/main/entry.c (0)
R ctags/main/entry.h (3)
R ctags/main/general.h (0)
R ctags/main/get.c (0)
R ctags/main/get.h (0)
R ctags/main/keyword.c (0)
R ctags/main/keyword.h (0)
R ctags/main/lregex.c (2)
R ctags/main/main.h (0)
A ctags/main/mio.c (1063)
A ctags/main/mio.h (178)
R ctags/main/nestlevel.c (0)
R ctags/main/nestlevel.h (0)
R ctags/main/options.c (0)
R ctags/main/options.h (0)
R ctags/main/parse.c (2)
R ctags/main/parse.h (0)
R ctags/main/parsers.h (2)
R ctags/main/read.c (0)
R ctags/main/read.h (2)
R ctags/main/sort.c (0)
R ctags/main/sort.h (0)
R ctags/main/strlist.c (0)
R ctags/main/strlist.h (0)
R ctags/main/vstring.c (0)
R ctags/main/vstring.h (0)
R ctags/makefile.win32 (0)
R ctags/parsers/abaqus.c (0)
R ctags/parsers/abc.c (0)
R ctags/parsers/actionscript.c (0)
R ctags/parsers/asciidoc.c (0)
R ctags/parsers/asm.c (0)
R ctags/parsers/basic.c (0)
R ctags/parsers/c.c (2)
R ctags/parsers/cobol.c (0)
R ctags/parsers/conf.c (0)
R ctags/parsers/css.c (0)
R ctags/parsers/diff.c (0)
R ctags/parsers/docbook.c (0)
R ctags/parsers/erlang.c (0)
R ctags/parsers/fortran.c (2)
R ctags/parsers/go.c (0)
R ctags/parsers/haskell.c (0)
R ctags/parsers/haxe.c (0)
R ctags/parsers/html.c (0)
R ctags/parsers/jscript.c (2)
R ctags/parsers/json.c (0)
R ctags/parsers/latex.c (0)
R ctags/parsers/lua.c (0)
R ctags/parsers/make.c (0)
R ctags/parsers/markdown.c (0)
R ctags/parsers/matlab.c (0)
R ctags/parsers/nsis.c (0)
R ctags/parsers/objc.c (0)
R ctags/parsers/pascal.c (0)
R ctags/parsers/perl.c (0)
R ctags/parsers/php.c (0)
R ctags/parsers/powershell.c (0)
R ctags/parsers/python.c (0)
R ctags/parsers/r.c (0)
R ctags/parsers/rest.c (0)
R ctags/parsers/ruby.c (0)
R ctags/parsers/rust.c (0)
R ctags/parsers/sh.c (0)
R ctags/parsers/sql.c (0)
R ctags/parsers/tcl.c (0)
R ctags/parsers/txt2tags.c (0)
R ctags/parsers/verilog.c (0)
R ctags/parsers/vhdl.c (0)
M doc/Doxyfile.in (10)
M doc/Makefile.am (4)
M plugins/Makefile.am (2)
M scripts/create_php_tags.py (4)
M src/Makefile.am (5)
M src/filetypes.h (2)
R src/tagmanager/Makefile.am (5)
R src/tagmanager/makefile.win32 (0)
R src/tagmanager/tm_ctags_wrappers.c (0)
R src/tagmanager/tm_ctags_wrappers.h (0)
R src/tagmanager/tm_parser.c (0)
R src/tagmanager/tm_parser.h (0)
R src/tagmanager/tm_source_file.c (0)
R src/tagmanager/tm_source_file.h (0)
R src/tagmanager/tm_tag.c (0)
R src/tagmanager/tm_tag.h (0)
R src/tagmanager/tm_workspace.c (0)
R src/tagmanager/tm_workspace.h (0)
D tagmanager/Makefile.am (3)
D tagmanager/ctags/Makefile.am (89)
D tagmanager/mio/COPYING (339)
D tagmanager/mio/Makefile.am (13)
D tagmanager/mio/README (3)
D tagmanager/mio/makefile.win32 (53)
D tagmanager/mio/mio-file.c (175)
D tagmanager/mio/mio-memory.c (480)
D tagmanager/mio/mio.c (656)
D tagmanager/mio/mio.h (221)
-- Patch Links --
https://github.com/geany/geany/pull/1070.patchhttps://github.com/geany/geany/pull/1070.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1070
Found by inspection, needs to be checked.
Both the plain C file IO and GIO (g_file_replace_contents) can leave the original file damaged if a failure occurs during a write. The normal advice is to "don't panic, you still have the buffer contents to save somewhere else", but if the save fails during a close Geany will still close, so now both the original file and the buffer are lost.
Basically `libmain.c` in `main_quit` should not ignore the return from `document_close_all()`.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1147
At the moment tags with identical names are stored into a linked list in
tags_table and parents_table. This however leads to quadratic complexity
when looking up the nearest parent or tag in tree because the whole list
has to be traversed.
Use binary trees indexed by line number instead of lists so the lookup can
be performed in log(N) time and the overall complexity is N*log(N) instead
of N^2.
The GTree API is a little stupid because during the search it doesn't give
access to the value and it doesn't tell when a leaf node was reached. For
this reason the lookup has to be made in two steps - first, the best line
number is found (returned in user_data) and then a normal search for the
found line number is made to get the value stored in the tree.
This patch fixes the problem described in #577 when e.g. a big json export
file contains many identically named tags.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/797
-- Commit Summary --
* Store "equal" tags into binary trees instead of lists in Symbol tree
-- File Changes --
M src/symbols.c (249)
-- Patch Links --
https://github.com/geany/geany/pull/797.patchhttps://github.com/geany/geany/pull/797.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/797