the optimization doesn't matter, it's merely getting an address and the dereferencing a pointer which ought to be cheap (like 2 additional instructions for each pointer), we're really not in any performance critical code where this kind of things matter. Not adding a dozen intermediate functions is probably better for code readability, and possibly for performance if they call isn't inlined.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
> If we get to move `get_doc_folder` and `utils_filename_has_prefix` to a shared location
`utils_filename_has_prefix()` is unnecessary but to implement `get_doc_folder()`, so if the latter is available there's no need for the former.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
Really looks like a GTK or WM bug to me. The part you don't see are the part that shuold work the best: they are drawn by GTK itself, with little to no customization on our part.
Interestingly, it probably also corresponds to the double-buffered part of the app.
Maybe try disabling composition on your WM.
And in all cases, 1.25 isn't too recent, maybe something got fixed since then.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/511#issuecomment-236389828
Hi! Not sure if it's the same problem, but every time I open Geany (in Lubuntu) the window doesn't render properly. I can load Geany and use it, but some features, like the toolbar and statusbar doesn't refresh properly.
I have installed geany 1.25 (built on 2015-07-12 with GTK 2.24.28, GLib 2.45.3). This is a screenshot:
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/511#issuecomment-236386331
If we get to move `get_doc_folder` and `utils_filename_has_prefix` to a shared location, it would just mean 11 more added lines in `get_doc_dirname` to have compatible sorting output with the sidebar's list.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
I'm thinking about expanding the compare functions to compare_tabs_based_on_{filename,pathname}_real(GeanyDocument *doc_a, GeanyDocument *doc_b)`, so we don't have to pass `&doc` and `&doc_b` and rely on implied optimization by the compiler. But I guess it's good enough.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
When `doc == doc_b`, `pos` should not increment since if the tab is moving from left to right (like when saving an untitled document to a new file), the target position should be `pos - 1`.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/b1528f01e240379c0f75ae0c2f50829b271c0…
I would like to have the possibility to see more lines beneath the cursor when the cursor is near the bottom of the text edit pane.
@b4n mentioned in the last paragraph of [his comment](https://github.com/geany/geany/issues/1116#issuecomment-230763662) to issue #1116
> However, we could indeed set [the Y caret policy](http://www.scintilla.org/ScintillaDoc.html#SCI_SETYCARETPOLICY) with an offset so the last line is never on the bottom, something like `SCI_SETYCARETPOLICY(CARET_SLOP | CARET_STRICT | CARET_EVEN, 1).`
> I guess that'd be reasonable, but may require a setting.
So my feature request is: Please implement such a setting, but please with more than just one single line - it would be nice to be able to freely set the number of lines.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1152