6f5d5db and d6d4728 disabled "maintain history on reload" by default,
with the intention to reenable it when we have a better method to
make it discoverable for the user. This was necessary since it became
enabled by default but could be surprising given Geany warned about
losing data before.
This commit tries to resolve the discoverability, by providing an
informational doc message that is shown once to the user, after the first
reload. The doc message also gives the option to disable this feature.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/672
-- Commit Summary --
* document: show informational doc message after first reload
-- File Changes --
M src/document.c (34)
M src/document.h (1)
M src/documentprivate.h (1)
M src/keyfile.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/672.patchhttps://github.com/geany/geany/pull/672.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/672
@kugel- well, this PR selects GTK3 automatically if GTK2 isn't found, which effectively means that it *can* be selected by default without explicit choice from the user. So issues with it worries me a little more than if it's an explicit, manual choice.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/524#issuecomment-152650817
Hi again!
I go to Preferences->Keybindings, I set collapse all to look up some specific menu, I expand a menu and set a specific keybinding, I close the window to try it, maybe I dislike it and I wanna change it back; so I again go to Preferences -> Keybindings but again all the menus are expanded and I have to look up again for the specific keybinding.
I think that Geany should remember how you left collapsed/expanded menus last time.
Whereas a search bar it's added for the keybindings or not, this would be appreciate.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/645
@b4n If you think it's fine to merge, I will do ;) Having a package time dependency is ok for me if we speed up build a lot. But I cannot say something about auto* quality
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/277#issuecomment-152551092
The default is still gtk2 isn't it? I don't understand why gtk3 issues hold this back (I also see the tab refresh issue, but only after upgrading to gtk 3.18)
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/524#issuecomment-152432739
configdir is initially in locale (glib) encoding. Converting it from UTF-8 is wrong (for example, "Р±РѕР·Р°" becomes "боза" on my system), and it must be converted _to_ UTF-8 when used in geany_debug() - otherwise, Help -> Debug Messages terminates Geany with an assertion. This is for POSIX only, under Windows the glib encoding is also UTF-8.
I replaced "alternate configdir %s" and "creating config directory %s" with static texts, because the directory is shown shortly after them as "User config dir: %s" anyway, and I don't want to create and free an utf8_configdir two more times.
dialogs_show_msgbox() in create_config_dir() are for the default directory only, and thus do not require conversion.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/658
-- Commit Summary --
* Fix configdir encoding
-- File Changes --
M src/libmain.c (12)
-- Patch Links --
https://github.com/geany/geany/pull/658.patchhttps://github.com/geany/geany/pull/658.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/658
@eht16 I added your commit that looks sensible, thanks.
Though, we're again close to a release (my bad) and I spotted a refresh issue on the current tab label color on GTK3, which is probably a GTK3 bug, so I'm a little more reluctant to enable GTK3 by default… err. Similarly, @elextr seems to have issue with certain corner cases on certain GTK3 versions as in https://github.com/geany/geany/issues/702#issuecomment-150986086 (although admittedly it was also broken on GTK2)
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/524#issuecomment-152351410