[Geany] hide menu bar on full-screen
mbrush at xxxxx
Sat Oct 22 22:38:49 UTC 2011
Is there any chance we could not commit this since I'll have to
re-convert the old Glade 2 file to Glade 3/GtkBuilder again? Once the
switch is complete I can hand-port the changes here.
I hate to cause extra effort since we appreciate when people can help
out but would it be possible for you to post this to the patch
tracker so that it doesn't get lost?
Also, it would be cool to generally add options to show/hide the menu
bar and the status bar, whether in fullscreen or not. There's already a
feature request about the status bar.
On 11-10-22 03:19 PM, Pedro Cirne wrote:
> "& ui_prefs.fullscreen" was redundant, state brings "ui_prefs.fullscreen
> & interface_prefs.hide_menubar_on_fullscreen" from caller. Now with
> tabs..I think it's ok!
> On Sat, Oct 22, 2011 at 6:03 PM, Dimitar Zhekov
> <dimitar.zhekov at gmail.com <mailto:dimitar.zhekov at gmail.com>> wrote:
> On Thu, 20 Oct 2011 12:43:15 +0100
> Pedro Cirne <pedro at cirne100.eu <mailto:pedro at cirne100.eu>> wrote:
> > Here it is...I hope it's useful!
> > On Thu, Oct 20, 2011 at 1:55 AM, Lex Trotman <elextr at gmail.com
> <mailto:elextr at gmail.com>> wrote:
> > > On 20 October 2011 11:39, Pedro Cirne <pedro at cirne100.eu
> <mailto:pedro at cirne100.eu>> wrote:
> > > > I have edited the source code to make it works for me, is it
> useful for
> > > the
> > > > project?
> > >
> > > If you submit a patch/pull request we will certainly have a look at
> > > it. Then you may not have to keep applying it each time Geany
> > > upgrades.
> Looks fine to me, except that some of the changes are indented with
> spaces instead of tabs.
> I'm not quite sure why ui_menubar_showhide() should take a gboolean
> state, check it with & and hide the menu for state = 1 (or TRUE?). It
> may be the most effective way, but writing an extra line or too to make
> the code stupid and simple may be a good idea.
> A good thing to have, though I personnaly am not going to use it.
> E-gards: Jimmy
> Geany mailing list
> Geany at uvena.de <mailto:Geany at uvena.de>
> Geany mailing list
> Geany at uvena.de
More information about the Users