[Geany] Visible whitespace

[Enrico Tröger]

On Thu, 20 Aug 2009 08:50:50 +1000, Lex wrote:

>2009/8/20 Enrico Tröger <enrico.troeger at uvena.de>:
>> On Wed, 19 Aug 2009 11:03:41 +1000, Lex wrote:
>>
>>>2009/8/19 Enrico Tröger <enrico.troeger at uvena.de>:
>>>> On Tue, 18 Aug 2009 16:37:43 +1000, Lex wrote:
>>>>
>>>>>Hi Lee,
>>>>>
>>>>>2009/8/18 Lee Gold <leegold at operamail.com>:
>>>>>>
>>>>>> I tried changing colors in files.common. Changing just color does
>>>>>> not solve the problem because the symbols are very tiny pin
>>>>>> pricks. Changing them to black or red does not help. Changing
>>>>>> background color from white totally disrupts the "look".
>>>>>
>>>>>Unfortunately AFAICT the visible whitespace display is hard coded
>>>>>in Scintilla, the editing component used by Geany
>>>>>(http://www.scintilla.org).  Geany can only turn it on/off.
>>>>>The best that can be done is to fiddle with the settings to
>>>>>minimise the disruption whilst maximising visibility.
>>>>
>>>> Another, in the long term more promising thing to be done is to
>>>> request this feature enhancement to the Scintilla project, once it
>>>> is available there, it will also be available in Geany (ok, maybe
>>>> with some little delay :D).
>>>> I don't know whether it's a coincidence or whether it was one
>>>> of you but today exactly this request was made:
>>>>
>>>> https://sourceforge.net/tracker/?func=detail&atid=352439&aid=2839427&group_id=2439
>>>
>>>I had a look at what was proposed above, it is probably the right way
>>>to do it.
>>>
>>>So I did it the wrong way ;-)
>>>
>>>To Neils eternal shame :-), the size of the dot is manifest constants
>>>in the code, the patch changes it to the symbol
>>>SCI_VISIBLE_WHITESPACE_SIZE with a default of one.
>>>
>>>To change it "make CXXFLAGS=-DSCI_VISIBLE_WHITESPACE_SIZE=2" or
>>>whatever size or configure it or however waf does these things.
>>>
>>>Patch is against scintilla in Geany.
>>
>> Nice!
>> I changed the value to 3 for testing and it gets pretty visible then
>> however I personally was also happy with the default but I see that
>> it might be too small/bright in some setups.
>>
>> About the code:
>> I'd like to see this code to be discussed with Neil, ideally in the
>> already existing feature request in the tracker. I think he would
>> accept it and so we don't need to patch our Scintilla copy again.
>> Ideally, the value could be changed with a message and not only by
>> changing constants in the source code,
>
>True, thats why I said I'd done it the wrong way.  But it only took
>half an hour, I don't have the time or knowledge to add a message to
>Scintilla.

Last week I spent a little time to write the necessary code around
your initial patch, sent it to the Scintilla mailing list and it got
committed. So, with the next Scintilla release, we can add a preference
for the size of the space character dots :).

I think we could wait for the next Scintilla release, 2.02, and then
update our copy in Geany.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/users/attachments/20090906/ad6944d0/attachment.pgp>