[Geany] Geany r3005 crash when typing {}

[Jason Oster]

Patch fixes the crash. With GDB, the problem was very obvious. 
Introduced in r2998 (whoops!)

http://geany.svn.sourceforge.net/viewvc/geany/trunk/src/editor.c?r1=2996&r2=2998

Frank Lanitz wrote:
> Hi, 
> 
> On Fri, 26 Sep 2008 16:26:19 +0200
> Harold Aling <geany at sait.nl> wrote:
> 
>> When editing a .php document and typing {} in a document, geany
>> crashes...
> 
> I can confirm this issue. I reproduced this by using a php document and
> typing 
> <?php
> foobaa{}
> 
> (gdb) bt
> #0  0x0000000000498cb9 in scintilla_send_message ()
> #1  0x000000000042f038 in lexer_has_braces (sci=0xf701e0830fe8c148) at ../src/editor.c:847
> #2  0x000000000042f59c in close_block (editor=0x27bcba0, pos=13) at ../src/editor.c:1058
> #3  0x000000000042e4d3 in on_char_added (editor=0x27bcba0, nt=0x7ffff3fc2ba0) at ../src/editor.c:456
> #4  0x000000000042ebe1 in on_editor_notification (widget=0x2930410, scn=0, lscn=0x7ffff3fc2ba0, user_data=0x29e03d0)
>     at ../src/editor.c:650
> #5  0x000000000049cd46 in scintilla_marshal_VOID__INT_POINTER (closure=0x32c4920, return_value=0x0, n_param_values=3, 
>     param_values=0x7ffff3fc2840, invocation_hint=0x7ffff3fc2740, marshal_data=0x0) at ../scintilla/scintilla-marshal.c:81
> #6  0x00007fe0ea804ebd in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #7  0x00007fe0ea817c2d in ?? () from /usr/lib/libgobject-2.0.so.0
> #8  0x00007fe0ea819116 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #9  0x00007fe0ea819623 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
> #10 0x000000000049aec3 in ScintillaGTK::NotifyParent ()
> #11 0x00000000004a4eb3 in Editor::NotifyChar ()
> #12 0x00000000004b017d in Editor::AddCharUTF ()
> #13 0x00000000004dc343 in ScintillaBase::AddCharUTF ()
> #14 0x0000000000499e6a in ScintillaGTK::CommitThis ()
> #15 0x00007fe0ea804ebd in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #16 0x00007fe0ea817c2d in ?? () from /usr/lib/libgobject-2.0.so.0
> #17 0x00007fe0ea819116 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #18 0x00007fe0ea819482 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
> #19 0x00007fe0ea804ebd in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #20 0x00007fe0ea817c2d in ?? () from /usr/lib/libgobject-2.0.so.0
> #21 0x00007fe0ea819116 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #22 0x00007fe0ea819482 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
> #23 0x00007fe0eb90848a in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #24 0x00007fe0eb908c8a in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #25 0x0000000000499550 in ScintillaGTK::KeyThis ()
> #26 0x00007fe0eb92a688 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #27 0x00007fe0ea804e0f in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #28 0x00007fe0ea8178fc in ?? () from /usr/lib/libgobject-2.0.so.0
> #29 0x00007fe0ea818f99 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #30 0x00007fe0ea819623 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
> #31 0x00007fe0eba3f19e in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #32 0x00007fe0eba4f9eb in gtk_window_propagate_key_event () from /usr/lib/libgtk-x11-2.0.so.0
> #33 0x00007fe0eba5292b in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #34 0x00007fe0eb92a688 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #35 0x00007fe0ea804ebd in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
> #36 0x00007fe0ea8178fc in ?? () from /usr/lib/libgobject-2.0.so.0
> #37 0x00007fe0ea818f99 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
> #38 0x00007fe0ea819623 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
> #39 0x00007fe0eba3f19e in ?? () from /usr/lib/libgtk-x11-2.0.so.0
> #40 0x00007fe0eb9232dd in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
> #41 0x00007fe0eb92424b in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
> #42 0x00007fe0eb585f8c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
> ---Type <return> to continue, or q <return> to quit---
> #43 0x00007fe0ea168892 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
> #44 0x00007fe0ea16c01d in ?? () from /usr/lib/libglib-2.0.so.0
> #45 0x00007fe0ea16c54d in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
> #46 0x00007fe0eb924667 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
> #47 0x0000000000470167 in main (argc=1, argv=0x7ffff3fc4a68) at ../src/main.c:900
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Geany mailing list
> Geany at uvena.de
> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: close_block_crash.patch
Type: text/x-diff
Size: 353 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/users/attachments/20080926/e428b43f/attachment.patch>