[Geany] [PATCH] Fixes for warnings and portability

Daniel Richard G. skunk at xxxxx
Wed Feb 20 22:22:12 UTC 2008


On Wed, 2008 Feb 20 06:53:51 -0600, Jeff Pohlmeyer wrote:
> 
> How about something like this:
> 
>  enum {
>   FOO,
>   BAR,
>   BAZ,
>   FBZ_LAST /* must be last*/
> }
> 

That's a much nicer idea! It's often the case that the last item is e.g. 
FOO_COUNT, that can be referenced as the number of preceding enum elements. 
Having a convention for _LAST makes more sense when a total count is not 
relevant, say, for bitfield names or sparse enum lists.

I have another patch to submit, a fix for the as-of-recently 
multiply-defined symbol "c_tags_ignore". It should be declared in 
tagmanager/options.c as extern. (By the way, would it not be appropriate 
for this file to include symbols.h, so that it can get at the "official" 
declaration of that array?)


--Daniel


-- 
NAME   = Daniel Richard G.       ##  Remember, skunks       _\|/_  meef?
EMAIL1 = skunk at iskunk.org        ##  don't smell bad---    (/o|o\) /
EMAIL2 = skunk at alum.mit.edu      ##  it's the people who   < (^),>
WWW    = http://www.******.org/  ##  annoy them that do!    /   \
--
(****** = site not yet online)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: geany3.patch
Type: text/x-diff
Size: 402 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/users/attachments/20080220/a5304dd1/attachment.patch>


More information about the Users mailing list