[geany/geany-plugins] a2453b: workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks"

LarsDW223 git-noreply at xxxxx
Thu Mar 1 20:56:52 UTC 2018


Branch:      refs/heads/master
Author:      LarsDW223 <lars_paulsen at web.de>
Committer:   LarsDW223 <lars_paulsen at web.de>
Date:        Thu, 01 Mar 2018 20:56:52 UTC
Commit:      a2453bfe17e99b5434433a94ace63797b8690d6e
             https://github.com/geany/geany-plugins/commit/a2453bfe17e99b5434433a94ace63797b8690d6e

Log Message:
-----------
workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks"

The key "Bookmarks" can be missing and that is not an error. So pass "NULL" for
parameter "error" on calling "g_key_file_get_string_list()". This prevents multiple
error messages from being written to one GErrror and so causing a GLib warning in
the debug messages. Fixes #714.


Modified Paths:
--------------
    workbench/src/wb_project.c

Modified: workbench/src/wb_project.c
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -1355,7 +1355,7 @@ gboolean wb_project_load(WB_PROJECT *prj, gchar *filename, GError **error)
 		gchar **bookmarks_strings;
 
 		/* Load project bookmarks from string list */
-		bookmarks_strings = g_key_file_get_string_list (kf, "Workbench", "Bookmarks", NULL, error);
+		bookmarks_strings = g_key_file_get_string_list (kf, "Workbench", "Bookmarks", NULL, NULL);
 		if (bookmarks_strings != NULL)
 		{
 			gchar **file, *abs_path;



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list