[geany/geany-plugins] c30d34: debugger: eliminate llvm warning

Jiří Techet git-noreply at xxxxx
Tue Mar 29 13:03:55 UTC 2016


Branch:      refs/heads/master
Author:      Jiří Techet <techet at gmail.com>
Committer:   Jiří Techet <techet at gmail.com>
Date:        Tue, 29 Mar 2016 13:03:55 UTC
Commit:      c30d34cf54b5eada62c53e9be43fb181e023c8a3
             https://github.com/geany/geany-plugins/commit/c30d34cf54b5eada62c53e9be43fb181e023c8a3

Log Message:
-----------
debugger: eliminate llvm warning

on_key_pressed() is an existing callback function so the pointer is
always non-NULL:

vtree.c:164:14: warning: comparison of function 'on_key_pressed' not equal to a null pointer is
      always true [-Wtautological-pointer-compare]
        if (NULL != on_key_pressed)
            ~~~~    ^~~~~~~~~~~~~~

Remove the unnecessary check.


Modified Paths:
--------------
    debugger/src/vtree.c

Modified: debugger/src/vtree.c
5 lines changed, 1 insertions(+), 4 deletions(-)
===================================================================
@@ -161,10 +161,7 @@ GtkWidget* vtree_create(watch_render_name on_render_name, watch_expression_chang
 	gtk_tree_view_set_level_indentation(GTK_TREE_VIEW(tree), 10);
 
 	/* connect signals */
-	if (NULL != on_key_pressed)
-	{
-		g_signal_connect(G_OBJECT(tree), "key-press-event", G_CALLBACK (on_key_pressed), NULL);
-	}
+	g_signal_connect(G_OBJECT(tree), "key-press-event", G_CALLBACK (on_key_pressed), NULL);
 
 	/* create columns */
 	



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list