[geany/geany-plugins] 6ebce8: pohelper: Fix a memory leak when removing fuzzy flag

Colomban Wendling git-noreply at xxxxx
Mon Feb 16 22:59:17 UTC 2015


Branch:      refs/heads/master
Author:      Colomban Wendling <ban at herbesfolles.org>
Committer:   Colomban Wendling <ban at herbesfolles.org>
Date:        Tue, 22 Apr 2014 16:14:10 UTC
Commit:      6ebce810274c2be48ba5dafa3c1df5697c9c07ca
             https://github.com/geany/geany-plugins/commit/6ebce810274c2be48ba5dafa3c1df5697c9c07ca

Log Message:
-----------
pohelper: Fix a memory leak when removing fuzzy flag


Modified Paths:
--------------
    build/pohelper.m4
    pohelper/src/gph-plugin.c

Modified: build/pohelper.m4
5 lines changed, 4 insertions(+), 1 deletions(-)
===================================================================
@@ -1,6 +1,9 @@
 AC_DEFUN([GP_CHECK_POHELPER],
 [
-    GP_ARG_DISABLE([PoHelper], [yes])
+    GP_ARG_DISABLE([PoHelper], [auto])
+
+    dnl We require GLib >= 2.22, and Geany only depends on 2.20
+    GP_CHECK_PLUGIN_DEPS([PoHelper], [GLIB], [glib-2.0 >= 2.22])
 
     GP_COMMIT_PLUGIN_STATUS([PoHelper])
 


Modified: pohelper/src/gph-plugin.c
3 lines changed, 1 insertions(+), 2 deletions(-)
===================================================================
@@ -1032,7 +1032,7 @@ on_kb_toggle_fuzziness (guint key_id)
     
     if (style == SCE_PO_MSGID) {
       gint msgid_line = line;
-      GPtrArray *flags = g_ptr_array_new ();
+      GPtrArray *flags = g_ptr_array_new_with_free_func (g_free);
       
       sci_start_undo_action (sci);
       
@@ -1061,7 +1061,6 @@ on_kb_toggle_fuzziness (guint key_id)
       
       sci_end_undo_action (sci);
       
-      g_ptr_array_foreach (flags, (GFunc) g_free, NULL);
       g_ptr_array_free (flags, TRUE);
     }
   }



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list