[geany/geany-plugins] f931e2: spellcheck: fix checking with cppcheck

Colomban Wendling git-noreply at xxxxx
Fri Feb 21 16:35:51 UTC 2014


Branch:      refs/heads/master
Author:      Colomban Wendling <ban at herbesfolles.org>
Committer:   Colomban Wendling <ban at herbesfolles.org>
Date:        Fri, 21 Feb 2014 16:35:51 UTC
Commit:      f931e296d4fadf8e8a8456348f7ee9ee3cf48158
             https://github.com/geany/geany-plugins/commit/f931e296d4fadf8e8a8456348f7ee9ee3cf48158

Log Message:
-----------
spellcheck: fix checking with cppcheck

cppcheck tests all preprocessor conditionals, but when the code tests
whether one is defined or not it tests simply with it defined or not,
but always to an empty value.  So, code testing whether a macro is
defined, but then relying on the macro expanding to a non-empty value,
cppcheck might very well detect a syntax error.

So, explicitly tell cppcheck to only test the SCE_PAS_DEFAULT=0 case
so it doesn't incorrectly test the SCE_PAS_DEFAULT= case.


Modified Paths:
--------------
    spellcheck/src/Makefile.am

Modified: spellcheck/src/Makefile.am
1 files changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -22,4 +22,5 @@ spellcheck_la_LIBADD = \
 	$(COMMONLIBS) \
 	$(ENCHANT_LIBS)
 
+AM_CPPCHECKFLAGS = -DSCE_PAS_DEFAULT=0
 include $(top_srcdir)/build/cppcheck.mk



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list