[geany/geany-plugins] 821565: Fix Warnings

elextr git-noreply at xxxxx
Sat Jun 15 10:10:25 UTC 2013


Branch:      refs/heads/master
Author:      elextr <elextr at gmail.com>
Committer:   elextr <elextr at gmail.com>
Date:        Sat, 15 Jun 2013 10:10:25 UTC
Commit:      821565ebdb87c81f9ff9dc6587672fc35ae82d55
             https://github.com/geany/geany-plugins/commit/821565ebdb87c81f9ff9dc6587672fc35ae82d55

Log Message:
-----------
Fix Warnings

Alias warnings by setting -fno-strict-aliasing flag, this disables
the optimisation so is safe (and matches Python).

String const warnings by -Wno-write-string flag, gcc notes that
the warning may be useful, but can be annoying when const is not
properly used on the pointers (defined by Python so not fixable).

geanypy-uiutils.c combo box warning by updating to GtkComboBoxText
to match changes to Geany API.


Modified Paths:
--------------
    geanypy/src/Makefile.am
    geanypy/src/geanypy-uiutils.c

Modified: geanypy/src/Makefile.am
1 files changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -8,6 +8,7 @@ geanypy_la_CPPFLAGS			=	@GEANY_CFLAGS@ @PYGTK_CFLAGS@ @PYTHON_CPPFLAGS@ \
 								-DGEANYPY_PYTHON_DIR="\"$(libdir)/geany/geanypy\"" \
 								-DGEANYPY_PLUGIN_DIR="\"$(datadir)/geany/geanypy/plugins\"" \
 								-UHAVE_CONFIG_H
+geanypy_la_CFLAGS           =   -fno-strict-aliasing -Wno-write-strings
 geanypy_la_LIBADD			=	@GEANY_LIBS@ @PYGTK_LIBS@ @PYTHON_LDFLAGS@ \
 								@PYTHON_EXTRA_LIBS@ @PYTHON_EXTRA_LDFLAGS@
 geanypy_la_SOURCES			=	geanypy-app.c \


Modified: geanypy/src/geanypy-uiutils.c
4 files changed, 2 insertions(+), 2 deletions(-)
===================================================================
@@ -123,8 +123,8 @@
 	{
 		GOB_CHECK(py_cbo, 1);
 		widget = pygobject_get(py_cbo);
-		GOB_TYPE_CHECK(widget, GTK_TYPE_COMBO_BOX_ENTRY, 1);
-		ui_combo_box_add_to_history(GTK_COMBO_BOX_ENTRY(widget), text, hist_len);
+		GOB_TYPE_CHECK(widget, GTK_TYPE_COMBO_BOX_TEXT, 1);
+		ui_combo_box_add_to_history(GTK_COMBO_BOX_TEXT(widget), text, hist_len);
 	}
 
 	Py_RETURN_NONE;



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list