[geany/geany-plugins] 494f00: fixing a bug: double clicking on a row in watches and autos sometimes caused crash because of wrong args list governor

[Alexander Petukhov]

Branch:      refs/heads/master
Author:      Alexander Petukhov <devel at apetukhov.ru>
Committer:   Alexander Petukhov <devel at apetukhov.ru>
Date:        Wed, 08 Feb 2012 18:59:30
Commit:      494f00d818c20ab4a7c6a6e4da3837684b89e5ca
             https://github.com/geany/geany-plugins/commit/494f00d818c20ab4a7c6a6e4da3837684b89e5ca

Log Message:
-----------
fixing a bug: double clicking on a row in watches and autos sometimes caused crash because of wrong args list governor


Modified Paths:
--------------
    debugger/ChangeLog
    debugger/TODO
    debugger/src/debug.c
    debugger/src/vtree.c
    debugger/src/wtree.c

Modified: debugger/ChangeLog
5 files changed, 5 insertions(+), 0 deletions(-)
===================================================================
@@ -1,3 +1,8 @@
 15-10-2011 	Alexander Petukhov <devel at apetukhov.ru>
 
 	* first release
+
+08-02-2012 	Alexander Petukhov <devel at apetukhov.ru>
+
+	* fixed a bug: double clicking on a row in watches and autos sometimes caused crash because of wrong args list governor
+


Modified: debugger/TODO
3 files changed, 3 insertions(+), 0 deletions(-)
===================================================================
@@ -5,6 +5,7 @@ BUGS:
 
 FEATURES:
 - custom tooltip with sticking facilities
+- don't hide a tooltip until run hasn't happent, move it if document is being scrolled
 - use lexer to lookup for a symbol under cursor when presenting a tooltip
 - jump to a frame (change frame that affects locals, watch etc., caused by clicking a frame in the stack trace tab/margin stack marker)
 - geany menu integration
@@ -17,3 +18,5 @@ FEATURES:
 - attach functionality: dbm_ methods providing target lists, common dialog
 - android support
 - bashdb support
+- windows support
+- gdb backend step speed


Modified: debugger/src/debug.c
2 files changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -483,7 +483,7 @@ gboolean on_watch_button_pressed_callback(GtkWidget *treeview, GdkEventButton *e
 			gchar *expression = NULL;
 			gtk_tree_model_get(model, &iter,
 				W_EXPRESSION, &expression,
-			    NULL);
+			    -1);
 
 			if (strlen(expression))
 			{


Modified: debugger/src/vtree.c
5 files changed, 4 insertions(+), 1 deletions(-)
===================================================================
@@ -155,7 +155,10 @@ void render_value(GtkTreeViewColumn *tree_column,
 	gtk_tree_view_set_level_indentation(GTK_TREE_VIEW(tree), 10);
 
 	/* connect signals */
-	g_signal_connect(G_OBJECT(tree), "key-press-event", G_CALLBACK (on_key_pressed), NULL);
+	if (NULL != on_key_pressed)
+	{
+		g_signal_connect(G_OBJECT(tree), "key-press-event", G_CALLBACK (on_key_pressed), NULL);
+	}
 
 	/* create columns */
 	GtkCellRenderer *renderer;


Modified: debugger/src/wtree.c
6 files changed, 4 insertions(+), 2 deletions(-)
===================================================================
@@ -64,9 +64,11 @@ static void add_empty_row()
 		W_NAME, "",
 		W_VALUE, "",
 		W_TYPE, "",
+		W_LAST_VISIBLE, "",
 		W_INTERNAL, "",
 		W_EXPRESSION, "",
-		W_VALUE, "",
+		W_STUB, 0,
+		W_CHANGED, 0,
 		W_VT, VT_NONE,
 		-1);
 
@@ -79,7 +81,7 @@ static void add_empty_row()
 /*
  * name column renderer
  */
-void on_render_name(GtkTreeViewColumn *tree_column,
+static void on_render_name(GtkTreeViewColumn *tree_column,
 	 GtkCellRenderer *cell,
 	 GtkTreeModel *tree_model,
 	 GtkTreeIter *iter,



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: TBD).