[geany/geany-plugins] 21a66f: fixing bugs: 1.wrong breakpoint set error message 2.crash on gdb exit without a stop reason

[Alexander Petukhov]

Branch:      refs/heads/master
Author:      Alexander Petukhov <devel at apetukhov.ru>
Committer:   Alexander Petukhov <devel at apetukhov.ru>
Date:        Sun, 08 Apr 2012 18:57:22
Commit:      21a66f2b718307ed19db816d120b089566c30c3b
             https://github.com/geany/geany-plugins/commit/21a66f2b718307ed19db816d120b089566c30c3b

Log Message:
-----------
fixing bugs: 1.wrong breakpoint set error message 2.crash on gdb exit without a stop reason


Modified Paths:
--------------
    debugger/ChangeLog
    debugger/TODO
    debugger/src/dbm_gdb.c

Modified: debugger/ChangeLog
9 files changed, 9 insertions(+), 0 deletions(-)
===================================================================
@@ -1,3 +1,12 @@
+08-04-2012 	Alexander Petukhov <devel at apetukhov.ru>
+
+	* fixed a bug with wrong error message when a breakpoint condition/hitscounr can't be set
+	* fixed a bug when gdb exits without a stop reason
+
+07-04-2012 	Alexander Petukhov <devel at apetukhov.ru>
+
+	* fixed a bug with calltips still being shown when a pointer leaves editor window
+
 04-04-2012 	Alexander Petukhov <devel at apetukhov.ru>
 
 	* fixing exiting with code case that was unhandled and caused SIGSEGV (gdb)


Modified: debugger/TODO
34 files changed, 19 insertions(+), 15 deletions(-)
===================================================================
@@ -1,23 +1,27 @@
 BUGS:
 
 FEATURES:
-- custom tooltip with sticking facilities
-- don't hide a tooltip until run hasn't happent, move it if document is being scrolled
-- use lexer to lookup for a symbol under cursor when presenting a tooltip
-- geany menu integration
-- toolbar buttons
+
+- debug callbacks names (refactoring)
+- gdb backend step speed
+- windows support
+
+- attach functionality: dbm_ methods providing target lists, common dialog
+- interrupt thread using stack window
+- step back
+
 - margin context menu
 - editor context menu (add watch, add/remove breakpoint)
-- step back
+
+- font from the geany settings for a message window
+- use left/right keys to collapse/expand in breakpoints tree
+- use lexer to lookup for a symbol under cursor when presenting a tooltip
+- a button in the upper right path of a right notebook for a hiding/showing button panel
+- minimum width of the debug panel notebooks
 - tree views column width/autowidth
-- attach functionality: dbm_ methods providing target lists, common dialog
+- custom tooltip on breaks and stack trace windows with code snippet around break or frame
+- custom tooltip(in an editor in debug mode) with sticking facilities
+- don't hide a tooltip until run hasn't happent, move it if document is being scrolled
+
 - android support
 - bashdb support
-- windows support
-- gdb backend step speed
-- debug callbacks names
-- interrupt thread using stack window
-- custom tooltip on breaks and stack trace windows with code snippet around break or frame
-- font from the geany settings for a message window
-- a button in the upper right path of a right notebook for a hiding/showing button panel
-- use left/right keys to collapse/expand in breakpoints tree


Modified: debugger/src/dbm_gdb.c
5 files changed, 3 insertions(+), 2 deletions(-)
===================================================================
@@ -497,7 +497,7 @@ static gboolean on_read_from_gdb(GIOChannel * src, GIOCondition cond, gpointer d
 			else
 			{
 				/* somehow, sometimes there can be no stop reason */
-				stop_reason = SR_END_STEPPING_RANGE;
+				stop_reason = SR_EXITED_NORMALLY;
 			}
 			
 			if (SR_BREAKPOINT_HIT == stop_reason || SR_END_STEPPING_RANGE == stop_reason || SR_SIGNAL_RECIEVED == stop_reason)
@@ -817,7 +817,6 @@ gboolean run(const gchar* file, const gchar* commandline, GList* env, GList *wit
 		commands = add_to_queue(commands, NULL, command->str, error_message->str, TRUE);
 
 		g_string_free(command, TRUE);
-		g_string_free(error_message, TRUE);
 
 		if (bp->hitscount)
 		{
@@ -841,6 +840,8 @@ gboolean run(const gchar* file, const gchar* commandline, GList* env, GList *wit
 			g_string_free(command, TRUE);
 		}
 
+		g_string_free(error_message, TRUE);
+
 		bp_index++;
 		biter = biter->next;
 	}


@@ Diff output truncated at 100000 characters. @@


--------------
This E-Mail was brought to you by github_commit_mail.py (Source: TBD).