SF.net SVN: geany-plugins:[1932] trunk/geany-plugins/treebrowser

[dimitrov-adrian at users.sourceforge.net]

Revision: 1932
          http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=1932&view=rev
Author:   dimitrov-adrian
Date:     2011-02-14 20:25:48 +0000 (Mon, 14 Feb 2011)

Log Message:
-----------
Try to prevent from potentially frees string literals (reported by kugel)

Modified Paths:
--------------
    trunk/geany-plugins/treebrowser/ChangeLog
    trunk/geany-plugins/treebrowser/src/treebrowser.c

Modified: trunk/geany-plugins/treebrowser/ChangeLog
===================================================================
--- trunk/geany-plugins/treebrowser/ChangeLog	2011-02-14 18:27:54 UTC (rev 1931)
+++ trunk/geany-plugins/treebrowser/ChangeLog	2011-02-14 20:25:48 UTC (rev 1932)
@@ -39,6 +39,12 @@
 
 14-02-2011 	Adrian Dimitrov 		<dimitrov.adrian at gmail.com>
 
+	* src/treebrowser.c
+		Try to prevent from potentially frees string literals (reported by kugel)
+
+
+14-02-2011 	Adrian Dimitrov 		<dimitrov.adrian at gmail.com>
+
 	* One year release (from the idea to working plugin, thanks for all for the support)
 
 	* src/treebrowser.c

Modified: trunk/geany-plugins/treebrowser/src/treebrowser.c
===================================================================
--- trunk/geany-plugins/treebrowser/src/treebrowser.c	2011-02-14 18:27:54 UTC (rev 1931)
+++ trunk/geany-plugins/treebrowser/src/treebrowser.c	2011-02-14 20:25:48 UTC (rev 1932)
@@ -223,8 +223,8 @@
 #endif
 }
 
-static gchar
-*path_is_in_dir(gchar* src, gchar* find)
+static gchar*
+path_is_in_dir(gchar* src, gchar* find)
 {
 	int i = 0;
 	gchar *diffed_path = "";
@@ -398,17 +398,17 @@
 static gchar *
 get_terminal()
 {
+	gchar 		*terminal;
 #ifdef G_OS_WIN32
-	return "cmd"
+	terminal = g_strdup("cms");
 #else
-	gchar 		*terminal;
 	const gchar *term = g_getenv("TERM");
 	if (term != NULL)
 		terminal = g_strdup(term);
 	else
 		terminal = g_strdup("xterm");
-	return terminal;
 #endif
+	return terminal;
 }
 
 static gboolean
@@ -861,7 +861,6 @@
 
 			treebrowser_expand_to_path(froot, path_current);
 
-			g_free(froot);
 		}
 
 		g_strfreev(path_segments);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.