SF.net SVN: geany-plugins:[1644] trunk/geany-plugins/treebrowser

dimitrov-adrian at users.sourceforge.net dimitrov-adrian at xxxxx
Sat Oct 9 10:02:52 UTC 2010


Revision: 1644
          http://geany-plugins.svn.sourceforge.net/geany-plugins/?rev=1644&view=rev
Author:   dimitrov-adrian
Date:     2010-10-09 10:02:52 +0000 (Sat, 09 Oct 2010)

Log Message:
-----------
Treebrowser: warnings fixes (patch by FraLan)

Modified Paths:
--------------
    trunk/geany-plugins/treebrowser/ChangeLog
    trunk/geany-plugins/treebrowser/src/treebrowser.c

Modified: trunk/geany-plugins/treebrowser/ChangeLog
===================================================================
--- trunk/geany-plugins/treebrowser/ChangeLog	2010-10-09 00:03:32 UTC (rev 1643)
+++ trunk/geany-plugins/treebrowser/ChangeLog	2010-10-09 10:02:52 UTC (rev 1644)
@@ -42,6 +42,8 @@
 	* src/treebrowser.c
 		Fixed translatable info
 			(thanks to Frank Lanitz  <frank(at)frank(dot)uvena(dot)de> for patch)
+		Fixed fixed bad code and compilation warning in unused vars
+			(thanks to Frank Lanitz  <frank(at)frank(dot)uvena(dot)de> for patch)
 		Fixed some compilation warnings
 		Try to prevent from "ISO C90 forbids mixed declarations and code" compile message
 

Modified: trunk/geany-plugins/treebrowser/src/treebrowser.c
===================================================================
--- trunk/geany-plugins/treebrowser/src/treebrowser.c	2010-10-09 00:03:32 UTC (rev 1643)
+++ trunk/geany-plugins/treebrowser/src/treebrowser.c	2010-10-09 10:02:52 UTC (rev 1644)
@@ -132,7 +132,7 @@
 static void 	treebrowser_bookmarks_set_state();
 static void 	treebrowser_load_bookmarks();
 static void 	gtk_tree_store_iter_clear_nodes(gpointer iter, gboolean delete_root);
-static gboolean treebrowser_rename_current();
+static void 	treebrowser_rename_current();
 static void 	load_settings();
 static gboolean save_settings();
 
@@ -467,7 +467,8 @@
 				else
 					name = NULL;
 			}
-			if (path_full = g_filename_from_uri(*line, NULL, NULL))
+			path_full = g_filename_from_uri(*line, NULL, NULL);
+			if (path_full != NULL)
 			{
 				if (g_file_test(path_full, G_FILE_TEST_EXISTS | G_FILE_TEST_IS_DIR))
 				{
@@ -616,15 +617,8 @@
 		/*
 		 * NEED TO REWORK THE CONCEPT
 		 */
-		return FALSE;
-		for (i = 0; path_segments[i]; i++)
-		{
-			path_search = g_build_filename(path_search, path_segments[i], NULL);
-			treebrowser_search(path_search, NULL);
-			return FALSE;
-		}
 
-		return TRUE;
+		return FALSE;
 	}
 	return FALSE;
 }
@@ -657,7 +651,7 @@
 	return FALSE;
 }
 
-static gboolean
+static void
 treebrowser_rename_current()
 {
 	GtkTreeSelection 	*selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(treeview));
@@ -665,7 +659,9 @@
 	GtkTreeModel 		*model;
 
 	if (gtk_tree_selection_get_selected(selection, &model, &iter))
+	{
 		treebrowser_iter_rename(&iter);
+	}
 }
 
 /* ------------------


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.



More information about the Plugins-Commits mailing list