<p></p>
<p><b>@eht16</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/3051#discussion_r878863316">scripts/print-tags.py</a>:</p>
<pre style='color:#555'>> +
+
+def print_tag(tag):
+ res = '{:<12}'.format(tag[TA_TYPE] + ': ')
+ if TA_VARTYPE in tag:
+ res += tag[TA_VARTYPE] + ' '
+ if TA_SCOPE in tag:
+ res += tag[TA_SCOPE] + ' :: '
+ res += tag[TA_NAME]
+ if TA_ARGLIST in tag:
+ res += tag[TA_ARGLIST]
+ if TA_INHERITS in tag:
+ res += ' extends ' + tag[TA_INHERITS]
+ if TA_POINTER in tag and tag[TA_POINTER] > 0:
+ res += ' flags: ' + str(tag[TA_POINTER])
+ sys.stdout.buffer.write(res.encode('utf-8'))
</pre>
<p dir="auto">I assume we are using <code class="notranslate">stdout.buffer</code> here because we are writing binary data to <code class="notranslate">stdout</code> and docs suggest to use <code class="notranslate">stdout.buffer</code> in such cases?<br>
If so, maybe a comment could document this so we won't ask ourselves again in a year or so :).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3051#pullrequestreview-980961844">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ67HK3QPIG7XDQN3LDVLIZ4LANCNFSM5J2AJTYQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ2TIN224BLXCHJQ4TLVLIZ4LA5CNFSM5J2AJTY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHJ4EUNA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3051/review/980961844</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3051#pullrequestreview-980961844",
"url": "https://github.com/geany/geany/pull/3051#pullrequestreview-980961844",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>